Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1258532

Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code

From Stephan Mueller <smueller@chronox.de>
Newsgroups linux.kernel
Subject Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code
Date 2015-10-29 03:10 +0100
Message-ID <qoKP7-2tr-5@gated-at.bofh.it> (permalink)
References <qoGit-7XK-3@gated-at.bofh.it> <qoGsa-815-7@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Am Mittwoch, 28. Oktober 2015, 14:19:29 schrieb Tim Chen:

Hi Tim,

>+
>+	/* check for dependent cpu features */
>+	if (!cpu_has_aes) {
>+		pr_err("aes_cbc_mb_mod_init: no aes support\n");
>+		err = -ENODEV;
>+		goto err1;
>+	}

In your post 0/5, you say that this mechanism needs AVX2. In the existing 
AESNI glue code I find

#ifdef CONFIG_X86_64
#ifdef CONFIG_AS_AVX2
        if (boot_cpu_has(X86_FEATURE_AVX2)) {

...

Why would that CPU check not be needed here?

Ciao
Stephan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 5/5] crypto: AES CBC multi-buffer glue code Tim Chen <tim.c.chen@linux.intel.com> - 2015-10-28 22:30 +0100
  Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code Stephan Mueller <smueller@chronox.de> - 2015-10-29 03:10 +0100
    Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code Tim Chen <tim.c.chen@linux.intel.com> - 2015-10-29 17:20 +0100
      Re: [PATCH 5/5] crypto: AES CBC multi-buffer glue code Tim Chen <tim.c.chen@linux.intel.com> - 2015-10-29 19:20 +0100

csiph-web