Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap

From	Mark Brown <broonie@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap
Date	2015-10-29 00:50 +0100
Message-ID	<qoIDD-Si-5@gated-at.bofh.it> (permalink)
References	<qokBk-2oh-27@gated-at.bofh.it> <qoyNX-35R-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Oct 28, 2015 at 12:43:51PM +0000, Charles Keepax wrote:
> On Tue, Oct 27, 2015 at 10:58:21PM +0100, Robert Jarzmik wrote:

Please delete unneeded context from mails when replying.  Doing this
makes it much easier to find your reply in the message, helping ensure
it won't be missed by people scrolling through the irrelevant quoted
material.

> Why is the necessary? I can't see an obvious sign that these
> writes bypass the cache in the non-regmap version, am I missing
> something? Also if this is necessary I would quite like it to be
> accompanied by a comment in the code to explain why it is safe to
> do this here. Regarding the inherent dangers of cache bypass I
> explained in my last email.

It's probably worth pointing out that the functionality in the regmap
API is essentially the same as the functionality in the old ASoC cache
code, a conversion should pretty much be a case of directly translating
API calls.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v3 1/2] ASoC: wm9713: convert to regmap Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-27 23:10 +0100
  [PATCH v3 2/2] ASoC: wm9713: use snd_soc_*() calls to update ac97 registers Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-27 23:10 +0100
  Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-10-28 14:20 +0100
    Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-28 21:50 +0100
      Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap Charles Keepax <ckeepax@opensource.wolfsonmicro.com> - 2015-10-29 18:30 +0100
        Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap Robert Jarzmik <robert.jarzmik@free.fr> - 2015-10-29 21:10 +0100
    Re: [PATCH v3 1/2] ASoC: wm9713: convert to regmap Mark Brown <broonie@kernel.org> - 2015-10-29 00:50 +0100

csiph-web