Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

From	"Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
Date	2015-10-28 23:20 +0100
Message-ID	<qoHex-5t-9@gated-at.bofh.it> (permalink)
References	<qo9cR-3CL-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

> On Oct 27, 2015, at 4:49 AM, Peter Oberparleiter <oberpar@linux.vnet.ibm.com> wrote:
> 
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
> 
> Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> Reviewed-by: Hannes Reinecke <hare@suse.de>
> Cc: stable@vger.kernel.org
> ---
> drivers/scsi/scsi_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
> 		return -EINVAL;
> 
> 	sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> -	return period;
> +	return count;
> }
> 
> static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,

Reviewed-by: Matthew R. Ochs <mrochs@linux.vnet.ibm.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter <oberpar@linux.vnet.ibm.com> - 2015-10-27 11:00 +0100
  Re: [RESEND PATCH] scsi_sysfs: Fix queue_ramp_up_period return code "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com> - 2015-10-28 23:20 +0100

csiph-web