Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258355

Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis

Show all headers | View raw

On Wed, 2015-10-28 at 19:13 +0100, Bogicevic Sasa wrote:
> This fixes all Alignment should match open parenthesis
> messages from checkpatch.pl

What you suggest is not at all generally accepted kernel style.

> diff --git a/drivers/staging/gdm724x/gdm_lte.c b/drivers/staging/gdm724x/gdm_lte.c
[]
> @@ -161,12 +161,15 @@ static int gdm_lte_emulate_arp(struct sk_buff *skb_in, u32 nic_type)
>  		return -ENOMEM;
>  	skb_reserve(skb_out, NET_IP_ALIGN);
>  
> -	memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
> +	memcpy(
> +		skb_put(skb_out, mac_header_len), mac_header_data,
>  		mac_header_len);

What's desired here is:

	memcpy(skb_put(skb_out, mac_header_len), mac_header_data,
	       mac_header_len);

Second line should be:
[tab][7 spaces]mac_header_len);

etc...

btw: Please run your _patches_ through checkpatch.pl, not just
use it to find style issues in files.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match open parenthesis Bogicevic Sasa <brutallesale@gmail.com> - 2015-10-28 19:20 +0100
  Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match  open parenthesis Joe Perches <joe@perches.com> - 2015-10-28 19:30 +0100
  Re: [PATCH 2/2] drivers:staging:gdm724x Fix Alignment should match  open parenthesis Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-28 20:00 +0100

csiph-web