Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate immediately

From	"Rafael J. Wysocki" <rjw@rjwysocki.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate immediately
Date	2015-10-28 17:00 +0100
Message-ID	<qoB98-4v0-27@gated-at.bofh.it> (permalink)
References	<qj2OK-A2-11@gated-at.bofh.it> <qoAwp-4gt-11@gated-at.bofh.it> <qoAPM-4nj-21@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wednesday, October 28, 2015 08:58:11 PM Viresh Kumar wrote:
> On 28-10-15, 16:31, Rafael J. Wysocki wrote:
> > Is the current code really problematic?
> 
> Its not problematic, but just that I didn't like special code written
> here.
> 
> Also, its a blocker for the next patch which tries to schedule work on
> all the policy->cpus together.

Well, the second statement above sort of contradicts the first one. :-)

I guess the answer is "it is problematic, because I can't do the other
optimization then".

To that I'd really suggest trying to rework the code to use timer
functions directly in the first place.

Thanks,
Rafael

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate immediately "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-28 07:00 +0100
  Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate  immediately Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-28 10:40 +0100
    Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate immediately "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-28 16:10 +0100
      Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate  immediately Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-28 16:30 +0100
        Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate  immediately Viresh Kumar <viresh.kumar@linaro.org> - 2015-10-28 16:50 +0100
        Re: [PATCH V3 2/5] cpufreq: ondemand: update sampling rate immediately "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2015-10-28 17:00 +0100

csiph-web