Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258266

[PATCH 09/12] perf symbols: Fix type error when reading a build-id

Show all headers | View raw

From: Dima Kogan <dima@secretsauce.net>

This was benign, but wrong. The build-id should live in a char[], not a char*[]

Signed-off-by: Dima Kogan <dima@secretsauce.net>
Link: http://lkml.kernel.org/r/87si6pfwz4.fsf@secretsauce.net
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/symbol-minimal.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/symbol-minimal.c b/tools/perf/util/symbol-minimal.c
index fd8477cacf88..48906333a858 100644
--- a/tools/perf/util/symbol-minimal.c
+++ b/tools/perf/util/symbol-minimal.c
@@ -337,7 +337,7 @@ int dso__load_sym(struct dso *dso, struct map *map __maybe_unused,
 		  symbol_filter_t filter __maybe_unused,
 		  int kmodule __maybe_unused)
 {
-	unsigned char *build_id[BUILD_ID_SIZE];
+	unsigned char build_id[BUILD_ID_SIZE];
 	int ret;
 
 	ret = fd__is_64_bit(ss->fd);
-- 
2.1.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[GIT PULL 00/12] perf/core improvements and fixes Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 07/12] perf stat: Cache aggregated map entries in extra cpumap Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 08/12] perf tools: Search for more options when passing args to -h Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 04/12] perf tools: Introduce usage_with_options_msg() Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 10/12] perf symbols: we can now read separate debug-info files based on a build ID Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 02/12] perf report: Rename to --show-cpu-utilization Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 11/12] perf tools: Enable pre-event inherit setting by config terms Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 12/12] perf symbols: Fix endless loop in dso__split_kallsyms_for_kcore Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 09/12] perf symbols: Fix type error when reading a build-id Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 01/12] perf tools: Improve ambiguous option help message Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  [PATCH 05/12] perf evsel: Move id_offset out of struct perf_evsel union member Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-28 16:40 +0100
  Re: [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2015-10-29 10:40 +0100
    Re: [GIT PULL 00/12] perf/core improvements and fixes Ingo Molnar <mingo@kernel.org> - 2015-10-29 11:00 +0100
    Re: [GIT PULL 00/12] perf/core improvements and fixes Jiri Olsa <jolsa@redhat.com> - 2015-10-29 11:00 +0100

csiph-web