Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources

From	Linus Walleij <linus.walleij@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] gpio: zynq: Implement irq_(request\|release)_resources
Date	2015-10-28 16:30 +0100
Message-ID	<qoAPM-4nj-29@gated-at.bofh.it> (permalink)
References	<qoePh-70a-33@gated-at.bofh.it> <qoePh-70a-31@gated-at.bofh.it> <qof8C-7mI-23@gated-at.bofh.it> <qofii-7q9-5@gated-at.bofh.it> <qogHo-8bo-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Oct 27, 2015 at 6:54 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:
> [Me]
>> Do you mean that these functions contain calls to non-atomic
>> functions?
>>
>
> Oh. No, I have to be more specific :(
> if GPIOx driver defines custom .irq_(request|release)_resources() callbacks
> they will *overwrite* standard GPIOirqchip callbacks.
> (commit: 8b67a1f "gpio: don't override irq_*_resources() callbacks")
>
> As result, such GPIOx driver should *re-implement* the same functionality in
> its .irq_(request|release)_resources() callbacks as implemented in
> gpiochip_irq_reqres()/gpiochip_irq_relres().

Yes that goes for all drivers not using gpiochip_add_irqchip().
Not everyone uses that ... and for those supplying their own
implementations of these functions.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources Linus Walleij <linus.walleij@linaro.org> - 2015-10-27 17:00 +0100
  Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-27 17:20 +0100
    Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources Linus Walleij <linus.walleij@linaro.org> - 2015-10-27 17:30 +0100
      Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources Grygorii Strashko <grygorii.strashko@ti.com> - 2015-10-27 19:00 +0100
        Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources Linus Walleij <linus.walleij@linaro.org> - 2015-10-28 16:30 +0100
  Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources Lars-Peter Clausen <lars@metafoo.de> - 2015-10-27 17:40 +0100
    Re: [PATCH] gpio: zynq: Implement irq_(request|release)_resources Thomas Gleixner <tglx@linutronix.de> - 2015-10-30 11:10 +0100

csiph-web