Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1258183

Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove function

Show all headers | View raw

Hi Andrew,

On 10/28/2015 03:35 PM, Andrew Lunn wrote:
> On Wed, Oct 28, 2015 at 03:13:16PM +0100, Neil Armstrong wrote:
>> diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xxx.c
>> index b1b14f5..6287096 100644
>> --- a/drivers/net/dsa/mv88e6xxx.c
>> +++ b/drivers/net/dsa/mv88e6xxx.c
>> @@ -331,6 +331,16 @@ void mv88e6xxx_ppu_state_init(struct dsa_switch *ds)
>>  	ps->ppu_timer.function = mv88e6xxx_ppu_reenable_timer;
>>  }
>>
>> +void mv88e6xxx_ppu_state_remove(struct dsa_switch *ds)
>> +{
>> +	struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
>> +	
>> +	del_timer_sync(&ps->ppu_timer);
>> +
>> +	cancel_work_sync(&ps->bridge_work);
>> +	flush_work(&ps->bridge_work);
>> +}
>> +
> 
> You add this function, but you don't use it anywhere?  Also, why
> cancel bridge work, not ppu_work? Or has that been consolidated
> in some patch i'm missing?
> 
>    Andrew
> 

It's called in the next patch, in mv88e6131_remove for mv88e6131.

Neil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove  function Neil Armstrong <narmstrong@baylibre.com> - 2015-10-28 15:20 +0100
  Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu remove  function Neil Armstrong <narmstrong@baylibre.com> - 2015-10-28 15:40 +0100
    Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu  remove function Andrew Lunn <andrew@lunn.ch> - 2015-10-28 15:50 +0100
  Re: [RFC PATCH v2 3/4] net: dsa: mv88e6xxx: add common and ppu  remove function Andrew Lunn <andrew@lunn.ch> - 2015-10-28 15:40 +0100

csiph-web