Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256545

Re: [PATCH] oom_kill: add option to disable dump_stack()

Show all headers | View raw

On Mon 26-10-15 13:40:49, Aristeu Rozanski wrote:
> Hi Michal,
> On Mon, Oct 26, 2015 at 06:20:12PM +0100, Michal Hocko wrote:
[...]
> > Would it make more sense to distinguish different parts of the OOM
> > report by loglevel properly?
> > pr_err - killed task report
> > pr_warning - oom invocation + memory info
> > pr_notice - task list
> > pr_info - stack trace
> 
> That'd work, yes, but I'd think the stack trace would be pr_debug. At a
> point that you suspect the OOM killer isn't doing the right thing picking
> up tasks and you need more information.

Stack trace should be independent on the oom victim selection because
the selection should be as much deterministic as possible - so it should
only depend on the memory consumption. I do agree that the exact trace
is not very useful for the (maybe) majority of OOM reports. I am trying
to remember when it was really useful the last time and have trouble to
find an example. So I would tend to agree that pr_debug would me more
suitable.
-- 
Michal Hocko
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] oom_kill: add option to disable dump_stack() Aristeu Rozanski <arozansk@redhat.com> - 2015-10-23 23:10 +0200
  Re: [PATCH] oom_kill: add option to disable dump_stack() Johannes Weiner <hannes@cmpxchg.org> - 2015-10-26 17:10 +0100
    Re: [PATCH] oom_kill: add option to disable dump_stack() Aristeu Rozanski <arozansk@redhat.com> - 2015-10-26 18:50 +0100
  Re: [PATCH] oom_kill: add option to disable dump_stack() Michal Hocko <mhocko@kernel.org> - 2015-10-26 18:30 +0100
    Re: [PATCH] oom_kill: add option to disable dump_stack() Aristeu Rozanski <arozansk@redhat.com> - 2015-10-26 18:50 +0100
      Re: [PATCH] oom_kill: add option to disable dump_stack() Michal Hocko <mhocko@kernel.org> - 2015-10-27 09:10 +0100
        Re: [PATCH] oom_kill: add option to disable dump_stack() Aristeu Rozanski <arozansk@redhat.com> - 2015-10-27 16:50 +0100
          Re: [PATCH] oom_kill: add option to disable dump_stack() Michal Hocko <mhocko@kernel.org> - 2015-10-27 17:30 +0100
            Re: [PATCH] oom_kill: add option to disable dump_stack() Aristeu Rozanski <arozansk@redhat.com> - 2015-10-27 19:00 +0100
              Re: [PATCH] oom_kill: add option to disable dump_stack() David Rientjes <rientjes@google.com> - 2015-10-29 01:00 +0100
  Re: [PATCH] oom_kill: add option to disable dump_stack() David Rientjes <rientjes@google.com> - 2015-10-26 22:40 +0100

csiph-web