Re: [RESEND PATCH v2] backlight: pm8941-wled: Add default-brightness property

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Rob Herring <robh+dt@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH v2] backlight: pm8941-wled: Add default-brightness property
Date	Tue, 27 Oct 2015 08:50:01 +0100
Message-ID	<qo7b3-2rZ-1@gated-at.bofh.it> (permalink)
References	<qnU4a-2JD-9@gated-at.bofh.it>
X-Original-To	Bjorn Andersson <bjorn.andersson@sonymobile.com>
X-Received	by 10.129.71.67 with SMTP id u64mr29512333ywa.82.1445931949524; Tue, 27 Oct 2015 00:45:49 -0700 (PDT)
MIME-Version	1.0
Content-Type	text/plain; charset=UTF-8
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	74
Organization	linux.* mail to news gateway
X-Original-Cc	Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>, Ian Campbell <ijc+devicetree@hellion.org.uk>, Jingoo Han <jingoohan1@gmail.com>, Lee Jones <lee.jones@linaro.org>, Jean-Christophe Plagniol-Villard <plagnioj@jcrosoft.com>, Tomi Valkeinen <tomi.valkeinen@ti.com>, Rob Clark <robdclark@gmail.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-fbdev@vger.kernel.org" <linux-fbdev@vger.kernel.org>, linux-arm-msm <linux-arm-msm@vger.kernel.org>
X-Original-Date	Tue, 27 Oct 2015 02:45:30 -0500
X-Original-Message-ID	<CAL_JsqLJE13F77r9x3-9wLgwJx1AqK8EDdnPoQL3a5anR-Y11w@mail.gmail.com>
X-Original-References	<1445881508-18025-1-git-send-email-bjorn.andersson@sonymobile.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1256535

Show key headers only | View raw

On Mon, Oct 26, 2015 at 12:45 PM, Bjorn Andersson
<bjorn.andersson@sonymobile.com> wrote:
> Default the brightness to 2048 and add possibility to override this in
> device tree.
>
> Suggested-by: Rob Clark <robdclark@gmail.com>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@sonymobile.com>
> ---
>
> Resend of v2, with updated backlight dt binding location.

Acked-by: Rob Herring <robh@kernel.org>

>
>  Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt | 2 ++
>  drivers/video/backlight/pm8941-wled.c                            | 8 ++++++++
>  2 files changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt b/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt
> index 424f8444a6cd..e5b294dafc58 100644
> --- a/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt
> +++ b/Documentation/devicetree/bindings/leds/backlight/pm8941-wled.txt
> @@ -5,6 +5,8 @@ Required properties:
>  - reg: slave address
>
>  Optional properties:
> +- default-brightness: brightness value on boot, value from: 0-4095
> +       default: 2048
>  - label: The name of the backlight device
>  - qcom,cs-out: bool; enable current sink output
>  - qcom,cabc: bool; enable content adaptive backlight control
> diff --git a/drivers/video/backlight/pm8941-wled.c b/drivers/video/backlight/pm8941-wled.c
> index c704c3236034..e1298147bcbb 100644
> --- a/drivers/video/backlight/pm8941-wled.c
> +++ b/drivers/video/backlight/pm8941-wled.c
> @@ -17,6 +17,9 @@
>  #include <linux/of_device.h>
>  #include <linux/regmap.h>
>
> +/* From DT binding */
> +#define PM8941_WLED_DEFAULT_BRIGHTNESS         2048
> +
>  #define PM8941_WLED_REG_VAL_BASE               0x40
>  #define  PM8941_WLED_REG_VAL_MAX               0xFFF
>
> @@ -373,6 +376,7 @@ static int pm8941_wled_probe(struct platform_device *pdev)
>         struct backlight_device *bl;
>         struct pm8941_wled *wled;
>         struct regmap *regmap;
> +       u32 val;
>         int rc;
>
>         regmap = dev_get_regmap(pdev->dev.parent, NULL);
> @@ -395,8 +399,12 @@ static int pm8941_wled_probe(struct platform_device *pdev)
>         if (rc)
>                 return rc;
>
> +       val = PM8941_WLED_DEFAULT_BRIGHTNESS;
> +       of_property_read_u32(pdev->dev.of_node, "default-brightness", &val);
> +
>         memset(&props, 0, sizeof(struct backlight_properties));
>         props.type = BACKLIGHT_RAW;
> +       props.brightness = val;
>         props.max_brightness = PM8941_WLED_REG_VAL_MAX;
>         bl = devm_backlight_device_register(&pdev->dev, wled->name,
>                                             &pdev->dev, wled,
> --
> 2.4.2
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RESEND PATCH v2] backlight: pm8941-wled: Add default-brightness property Bjorn Andersson <bjorn.andersson@sonymobile.com> - 2015-10-26 18:50 +0100
  Re: [RESEND PATCH v2] backlight: pm8941-wled: Add default-brightness property Rob Herring <robh+dt@kernel.org> - 2015-10-27 08:50 +0100
  Re: [RESEND PATCH v2] backlight: pm8941-wled: Add default-brightness  property Lee Jones <lee.jones@linaro.org> - 2015-10-30 19:50 +0100

csiph-web