Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using gpiolib

Path	csiph.com!news.mixmin.net!aioe.org!bofh.it!news.nic.it!robomod
From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using gpiolib
Date	Tue, 27 Oct 2015 09:20:03 +0100
Message-ID	<qo7E7-2QQ-9@gated-at.bofh.it> (permalink)
References	<qa5iO-5JO-13@gated-at.bofh.it> <qa5iQ-5JO-65@gated-at.bofh.it> <qnWSl-4rz-5@gated-at.bofh.it> <qo7up-2NF-7@gated-at.bofh.it>
X-Original-To	Roger Quadros <rogerq@ti.com>
X-Mailer	Claws Mail 3.11.1 (GTK+ 2.24.27; x86_64-pc-linux-gnu)
MIME-Version	1.0
Content-Type	text/plain; charset=US-ASCII
Content-Transfer-Encoding	7bit
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	48
Organization	linux.* mail to news gateway
X-Original-Cc	Brian Norris <computersforpeace@gmail.com>, <tony@atomide.com>, <dwmw2@infradead.org>, <ezequiel@vanguardiasur.com.ar>, <javier@dowhile0.org>, <fcooper@ti.com>, <nsekhar@ti.com>, <linux-mtd@lists.infradead.org>, <linux-omap@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Alex Smith <alex.smith@imgtec.com>, Harvey Hunt <harvey.hunt@imgtec.com>
X-Original-Date	Tue, 27 Oct 2015 09:12:35 +0100
X-Original-Message-ID	<20151027091235.03dba8c5@bbrezillon>
X-Original-References	<1442588029-13769-1-git-send-email-rogerq@ti.com> <1442588029-13769-19-git-send-email-rogerq@ti.com> <20151026204900.GI13239@google.com> <562F2FB6.7050806@ti.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1256550

Show key headers only | View raw

Hi Roger,

On Tue, 27 Oct 2015 10:03:02 +0200
Roger Quadros <rogerq@ti.com> wrote:

> On 26/10/15 22:49, Brian Norris wrote:
> > 
> > Others have been looking at using GPIOs for the ready/busy pin too. At a
> > minimum, we need an updated DT binding doc for this, since I see you're
> > adding this via device tree in a later patch (I don't see any DT binding
> > patch for this; but I could just be overlooking it). It'd also be great
> > if this support was moved to nand_dt_init() so other platforms can
> > benefit, but I won't require that.
> > 
> > Also, previous [0] proposers had suggested 'rb-gpios', not 'ready-gpio'
> > (the hardware docs typically call it 'rb' for ready/busy, FWIW). I don't
> > really care, but the name should be going into a doc, so we can choose
> > the same one everywhere.
> > 
> > EDIT: looks like the discussion was partly here [1] and it seems we're
> > landing on "rb-gpios" in the latest version [2]. Can we stick with that?
> 
> Why should it be "rb-gpios" and not "rb-gpio"?
> I don't think there are multiple gpios for r/b# function.

Because it's supposed to be a generic binding, and some NAND chips
embed several dies, thus exposing several CS and RB pins, hence the
rb-gpios name.
Also, as described here [1], the convention is to name your property
<name>-gpios even if you only need one gpio.

Best Regards,

Boris

[1]http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/gpio/gpio.txt#L16



-- 
Boris Brezillon, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using  gpiolib Brian Norris <computersforpeace@gmail.com> - 2015-10-26 21:50 +0100
  Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using  gpiolib Roger Quadros <rogerq@ti.com> - 2015-10-27 09:10 +0100
    Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using  gpiolib Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-27 09:20 +0100
      Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using  gpiolib Roger Quadros <rogerq@ti.com> - 2015-10-27 09:50 +0100
  Re: [PATCH v3 18/27] mtd: nand: omap2: Implement NAND ready using  gpiolib Boris Brezillon <boris.brezillon@free-electrons.com> - 2015-10-27 09:30 +0100

csiph-web