Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256512

Re: [PATCH 1/1] kthread: introduce kthread_get_run() to fix __nbd_ioctl()

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi,

On Mon, Oct 26, 2015 at 05:26:42PM -0700, Christoph Hellwig wrote:
> On Sun, Oct 25, 2015 at 03:27:13PM +0100, Oleg Nesterov wrote:
> > It is not safe to use the task_struct returned by kthread_run(threadfn)
> > if threadfn() can exit before the "owner" does kthread_stop(), nothing
> > protects this task_struct.
> > 
> > So __nbd_ioctl() looks buggy; a killed nbd_thread_send() can exit, free
> > its task_struct, and then kthread_stop() can use the freed/reused memory.
> > 
> > Add the new trivial helper, kthread_get_run(). Hopefully it will have more
> > users, this patch changes __nbd_ioctl() as an example.
> 
> This looks horrible.  I think the real problem is that nbd is totally
> abusing signals for kthreads and that needs to go away.

To avoid this kthread_get_run() we can change the NBD code as well to
guarantee that the thread does not exit until kthread_stop() was called.
I think that is independent of using signals.

Currently NBD uses signals for the timeout handling to get the threads
out of the TCP operations. Do you have an idea how to solve this
differently?

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/1] kthread: introduce kthread_get_run() to fix  __nbd_ioctl() Oleg Nesterov <oleg@redhat.com> - 2015-10-25 14:40 +0100
  [PATCH 1/1] kthread: introduce kthread_get_run() to fix  __nbd_ioctl() Oleg Nesterov <oleg@redhat.com> - 2015-10-25 14:40 +0100
    Re: [PATCH 1/1] kthread: introduce kthread_get_run() to fix  __nbd_ioctl() Markus Pargmann <mpa@pengutronix.de> - 2015-10-26 08:40 +0100
      Re: [PATCH 1/1] kthread: introduce kthread_get_run() to fix  __nbd_ioctl() Oleg Nesterov <oleg@redhat.com> - 2015-10-28 15:40 +0100
    Re: [PATCH 1/1] kthread: introduce kthread_get_run() to fix  __nbd_ioctl() Christoph Hellwig <hch@infradead.org> - 2015-10-27 01:30 +0100
      Re: [PATCH 1/1] kthread: introduce kthread_get_run() to fix  __nbd_ioctl() Markus Pargmann <mpa@pengutronix.de> - 2015-10-27 08:10 +0100
      Re: [PATCH 1/1] kthread: introduce kthread_get_run() to fix  __nbd_ioctl() Oleg Nesterov <oleg@redhat.com> - 2015-10-28 15:50 +0100

csiph-web