RE: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	"Winkler, Tomas" <tomas.winkler@intel.com>
Newsgroups	linux.kernel
Subject	RE: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output
Date	Sun, 25 Oct 2015 13:50:01 +0100
Message-ID	<qnsUh-332-5@gated-at.bofh.it> (permalink)
References	<qb4b0-nG-17@gated-at.bofh.it> <qfPuF-7an-1@gated-at.bofh.it> <qgffs-1Q6-13@gated-at.bofh.it> <qgg1R-30J-33@gated-at.bofh.it> <qgw6B-13i-13@gated-at.bofh.it>
X-Original-To	'Greg Kroah-Hartman' <gregkh@linuxfoundation.org>
X-Extloop1	1
X-Ironport-Av	E=Sophos;i="5.20,196,1444719600"; d="scan'208";a="587618138"
Thread-Topic	[char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output
Thread-Index	AQHQ9ENxBpLnnCCbYEGU8j0YleXRgp5bEiUAgAH9xsD//9rTAIABTsSggB4jVuA=
Accept-Language	en-US
Content-Language	en-US
X-Originating-IP	[10.184.70.10]
Content-Type	text/plain; charset="us-ascii"
Content-Transfer-Encoding	8BIT
MIME-Version	1.0
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	47
Organization	linux.* mail to news gateway
X-Original-Cc	"Usyskin, Alexander" <alexander.usyskin@intel.com>, "'linux-kernel@vger.kernel.org'" <linux-kernel@vger.kernel.org>, "'Alexander Kuleshov'" <kuleshovmail@gmail.com>
X-Original-Date	Sun, 25 Oct 2015 12:45:30 +0000
X-Original-Message-ID	<5B8DA87D05A7694D9FA63FD143655C1B41E31E59@hasmsx108.ger.corp.intel.com>
X-Original-References	<1442822295-5111-1-git-send-email-tomas.winkler@intel.com> <20151004111906.GA23333@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B3D45F060@hasmsx108.ger.corp.intel.com> <20151005153036.GA16834@kroah.com> <5B8DA87D05A7694D9FA63FD143655C1B3D45F67F@hasmsx108.ger.corp.intel.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1255386

Show key headers only | View raw

> 
> > > > >  		goto err;
> > > >
> > > > You should never care if a debugfs call fails or not.
> > >
> > > The system should not be dependent on the debug feature but, it is
> > > always good to know if there our system is failing
> >
> > And what can you do if it is "failing"?  Really nothing, so there's
> > nothing to check here.
> 
> As far as I can see the function debugfs_create_file may fail for a few reasons and
> it return  NULL if this is happening.
> I might ignore the error as you suggested, but I'm not sure why not to give a hint
> in log that this happened.
> Second, as far as I scanned the kernel sources, checking the return value of this
> function and acting on this is very common.
> 
> > >   Also, this will
> > > > "fail" if you don't have CONFIG_DEBUGFS enabled, which means you are
> > > > using the api wrong :(
> > >
> > > The whole file is not compiled if CONFIG_DEBUGFS is not set, please see the
> > Makefile
> >
> > Ok, then you don't need to check anything.  Debugfs was created to be
> > dirt-simple, don't add complexity and "must unwind cleanly" type logic
> > here where it's not needed at all.  That just hurts my sensibilities for
> > why I made the API the way it is in the first place :)
> 
> I don't see the code much complex, it is pretty much boilerplate code and this is
> why this c&p error had happened.
> So this patch just fixes a c&p error in an error message and if we wish to change
> the behavior to match your vision
> I suggest to doing it another patch set... maybe even sweeping the whole kernel.


Greg, are you merging this patch? What is your final say?

Thanks
Tomas 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

RE: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output "Winkler, Tomas" <tomas.winkler@intel.com> - 2015-10-25 13:50 +0100
  Re: [char-misc 1/2 4.3 V2] mei: Fix debugfs filename in error output 'Greg Kroah-Hartman' <gregkh@linuxfoundation.org> - 2015-10-25 18:00 +0100

csiph-web