Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1255303

Re: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec

Show all headers | View raw

On Mon, Oct 19, 2015 at 09:33:20AM +0200, dave penkler wrote:
> 
> Implement support for the USB488 defined READ_STATUS_BYTE and SRQ
> notifications with ioctl, fasync and poll/select in order to be able
> to synchronize with variable duration instrument operations.
> 
> Add ioctls for other USB488 requests: REN_CONTROL, GOTO_LOCAL and
> LOCAL_LOCKOUT.
> 
> Add convenience ioctl to return all device capabilities.

Can you break this up into a series of patches, all doing only one
thing?  You are doing a lot of different things in this single patch,
making it almost impossible to review :(

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488 spec dave penkler <dpenkler@gmail.com> - 2015-10-19 09:40 +0200
  Re: [PATCH V2] USB: usbtmc: Add support for missing USBTMC-USB488  spec Greg KH <gregkh@linuxfoundation.org> - 2015-10-25 09:40 +0100

csiph-web