Re: + signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch added to -mm tree

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Markus Pargmann <mpa@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: + signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch added to -mm tree
Date	Sat, 24 Oct 2015 22:10:01 +0200
Message-ID	<qndix-2dU-3@gated-at.bofh.it> (permalink)
References	<qnd8R-1Nx-3@gated-at.bofh.it> <qnd8R-1Nx-5@gated-at.bofh.it> <qnd8R-1Nx-1@gated-at.bofh.it>
X-Original-To	Oleg Nesterov <oleg@redhat.com>
MIME-Version	1.0
Content-Type	multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="jho1yZJdad60DJr+"
Content-Disposition	inline
X-Sent-From	Pengutronix Hildesheim
X-URL	http://www.pengutronix.de/
X-Irc	#ptxdist @freenode
X-Accept-Language	de,en
X-Accept-Content-Type	text/plain
X-Uptime	22:05:15 up 35 days, 9:26, 125 users, load average: 0.84, 0.56, 1.33
User-Agent	Mutt/1.5.24 (2015-08-30)
X-Sa-Exim-Connect-IP	2001:67c:670:100:1d::7
X-Sa-Exim-Mail-From	mpa@pengutronix.de
X-Sa-Exim-Scanned	No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false
X-Ptx-Original-Recipient	linux-kernel@vger.kernel.org
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	97
Organization	linux.* mail to news gateway
X-Original-Cc	akpm@linux-foundation.org, balbi@ti.com, dwmw2@infradead.org, tj@kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sat, 24 Oct 2015 22:09:18 +0200
X-Original-Message-ID	<20151024200918.GB16521@pengutronix.de>
X-Original-References	<5612e95f.di8YWOS7lWDxbMSm%akpm@linux-foundation.org> <20151024191053.GA16521@pengutronix.de> <20151024194826.GA14895@redhat.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1255243

Show key headers only | View raw

[Multipart message — attachments visible in raw view] - view raw

Hi Oleg,

On Sat, Oct 24, 2015 at 09:48:26PM +0200, Oleg Nesterov wrote:
> Hi Markus,
> 
> s/mm-commits/lkml/
> 
> On 10/24, Markus Pargmann wrote:
> >
> > On Mon, Oct 05, 2015 at 02:19:27PM -0700, akpm@linux-foundation.org wrote:
> > >
> > > Subject: signal: turn dequeue_signal_lock() into kernel_dequeue_signal()
> > >
> > > 1. Rename dequeue_signal_lock() to kernel_dequeue_signal(). This
> > >    matches another "for kthreads only" kernel_sigaction() helper.
> > >
> > > 2. Remove the "tsk" and "mask" arguments, they are always current
> > >    and current->blocked. And it is simply wrong if tsk != current.
> > >
> > > 3. We could also remove the 3rd "siginfo_t *info" arg but it looks
> > >    potentially useful. However we can simplify the callers if we
> > >    change kernel_dequeue_signal() to accept info => NULL.
> > >
> > > 4. Remove _irqsave, it is never called from atomic context.
> >
> > I just realised that this patch will conflict with a fixup patch for nbd
> > that will be included in rc7.
> >
> > dcc909d90ccd (nbd: Add locking for tasks)
> >
> > I think there is basically one new instance of dequeue_signal_lock() that
> > needs to be replaced with kernel_dequeue_signal().
> 
> Thanks! I'll send *-fix.patch to Andrew.
> 
> But you know, dcc909d90ccd (nbd: Add locking for tasks) doesn't look exactly
> right at first glance, although I need to re-check tomorrow...

In which regard? Is the locking incorrect or am I doing something wrong
with the signal handling?

> 
> One question, can sock_xmit() be called from user space? Or it is only called
> by kthreads?

sock_xmit() can be called by a thread that entered from userspace. In
general the idea is that there are no pending signals when it leaves
into userspace again.

Best Regards,

Markus

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Thread

Re: +  signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch  added to -mm tree Oleg Nesterov <oleg@redhat.com> - 2015-10-24 22:00 +0200
  Re: +  signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch added to  -mm tree Markus Pargmann <mpa@pengutronix.de> - 2015-10-24 22:10 +0200
    Re: +  signal-turn-dequeue_signal_lock-into-kernel_dequeue_signal.patch  added to -mm tree Oleg Nesterov <oleg@redhat.com> - 2015-10-25 13:40 +0100

csiph-web