Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256223

[PATCH -rt] Revert "net: use synchronize_rcu_expedited()"

Show all headers | View raw

This reverts commit be3fc413da9eb17cce0991f214ab019d16c88c41.

While the use of synchronize_rcu_expedited() might make
synchronize_net() "faster", it does so at significant cost on RT
systems, as expediting a grace period forcibly preempts any
high-priority RT tasks (via the stop_machine() mechanism).

Without be3fc413da9e reverted, we can observe a latency spike up to 30us
with cyclictest by rapidly unplugging/reestablishing an ethernet link.

Cc: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Cc: David S. Miller <davem@davemloft.net>
Signed-off-by: Josh Cartwright <joshc@ni.com>
---
 net/core/dev.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/net/core/dev.c b/net/core/dev.c
index f8c23de..869ef62 100644
--- a/net/core/dev.c
+++ b/net/core/dev.c
@@ -6969,10 +6969,7 @@ EXPORT_SYMBOL(free_netdev);
 void synchronize_net(void)
 {
 	might_sleep();
-	if (rtnl_is_locked())
-		synchronize_rcu_expedited();
-	else
-		synchronize_rcu();
+	synchronize_rcu();
 }
 EXPORT_SYMBOL(synchronize_net);
 
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH -rt] Revert "net: use synchronize_rcu_expedited()" Josh Cartwright <joshc@ni.com> - 2015-10-26 20:20 +0100
  Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-10-27 01:50 +0100
    Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" Josh Cartwright <joshc@ni.com> - 2015-10-27 13:40 +0100
      Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" Eric Dumazet <eric.dumazet@gmail.com> - 2015-10-27 15:20 +0100
        Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-27 16:10 +0100
          Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" Eric Dumazet <eric.dumazet@gmail.com> - 2015-10-27 16:30 +0100
            Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-10-28 00:20 +0100
              Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" Josh Cartwright <joshc@ni.com> - 2015-10-28 09:40 +0100
                Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2015-10-28 13:30 +0100
        Re: [PATCH -rt] Revert "net: use synchronize_rcu_expedited()" David Miller <davem@davemloft.net> - 2015-10-30 10:20 +0100

csiph-web