[PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests

From	"Felipe F. Tonello" <eu@felipetonello.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests
Date	2015-10-26 18:00 +0100
Message-ID	<qnThM-2d0-1@gated-at.bofh.it> (permalink)
References	<qnThM-2d0-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

This patch fixes a memory leak that occurs when an endpoint fails to enqueue
the request. If that happens the complete function will never be called, thus
never freeing the request.

Signed-off-by: Felipe F. Tonello <eu@felipetonello.com>
---
 drivers/usb/gadget/function/f_midi.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/usb/gadget/function/f_midi.c b/drivers/usb/gadget/function/f_midi.c
index 4c01c8a..0e9cdeb 100644
--- a/drivers/usb/gadget/function/f_midi.c
+++ b/drivers/usb/gadget/function/f_midi.c
@@ -344,6 +344,7 @@ static int f_midi_set_alt(struct usb_function *f, unsigned intf, unsigned alt)
 		if (err) {
 			ERROR(midi, "%s queue req: %d\n",
 				    midi->out_ep->name, err);
+			free_ep_req(midi->out_ep, req);
 		}
 	}
 
-- 
2.1.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue out requests "Felipe F. Tonello" <eu@felipetonello.com> - 2015-10-26 18:00 +0100
  Re: [PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue  out requests Robert Baldyga <r.baldyga@hackerion.com> - 2015-10-26 23:30 +0100
    Re: [PATCH v4 4/7] usb: gadget: f_midi: fix leak on failed to enqueue  out requests Felipe Tonello <eu@felipetonello.com> - 2015-10-27 00:00 +0100

csiph-web