Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1256090

[PATCH] scsi_sysfs: Fix queue_ramp_up_period return code

Show all headers | View raw

Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
returns the value of that number instead of the number of bytes written.
This behavior can confuse programs expecting POSIX write() semantics.
Fix this by returning the number of bytes written instead.

Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
---
 drivers/scsi/scsi_sysfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
index b333389..6b0f292 100644
--- a/drivers/scsi/scsi_sysfs.c
+++ b/drivers/scsi/scsi_sysfs.c
@@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
 		return -EINVAL;

 	sdev->queue_ramp_up_period = msecs_to_jiffies(period);
-	return period;
+	return count;
 }

 static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
-- 
2.3.0

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter <oberpar@linux.vnet.ibm.com> - 2015-10-26 16:00 +0100
  Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Bart Van Assche <bvanassche@acm.org> - 2015-10-27 03:30 +0100
  Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Hannes Reinecke <hare@suse.de> - 2015-10-27 08:00 +0100
  Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Ewan Milne <emilne@redhat.com> - 2015-10-27 17:20 +0100

csiph-web