Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1255854

[RFC PATCH v2 2/2] perf tools: Don't set inherit bit for system wide evsel

Show all headers | View raw

Inherit bit is useless for a system wide evsel [1]. Further kernel
improvements are giving more constrain [2] on inherit events. This
patch set inherit bit to 0 for system wide evsels to avoid potential
constrains.

[1] http://lkml.kernel.org/r/20151022124142.GQ17308@twins.programming.kicks-ass.net
[2] http://lkml.kernel.org/r/1445559014-4667-1-git-send-email-ast@kernel.org

Signed-off-by: Wang Nan <wangnan0@huawei.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Alexei Starovoitov <ast@plumgrid.com>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Li Zefan <lizefan@huawei.com>
Cc: pi3orama@163.com
Link: http://lkml.kernel.org/n/ebpf-0xsuv8wc1uwgj7qfylfolgqs@git.kernel.org
---
 tools/perf/util/evsel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
index 36ecf0e..2a5f0f8 100644
--- a/tools/perf/util/evsel.c
+++ b/tools/perf/util/evsel.c
@@ -736,7 +736,7 @@ void perf_evsel__config(struct perf_evsel *evsel, struct record_opts *opts)
 
 	evsel->system_wide = opts->target.system_wide;
 	attr->sample_id_all = perf_missing_features.sample_id_all ? 0 : 1;
-	attr->inherit	    = !opts->no_inherit;
+	attr->inherit	    = !opts->no_inherit && !evsel->system_wide;
 
 	perf_evsel__set_sample_bit(evsel, IP);
 	perf_evsel__set_sample_bit(evsel, TID);
-- 
1.8.3.4

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[RFC PATCH v2 0/2] perf tools: Don't set inherit bit for system wide evsel Wang Nan <wangnan0@huawei.com> - 2015-10-26 12:50 +0100
  [RFC PATCH v2 2/2] perf tools: Don't set inherit bit for system wide evsel Wang Nan <wangnan0@huawei.com> - 2015-10-26 12:50 +0100
  [RFC PATCH v2 1/2] perf tools: Set evsel->system_wide field for global system wide recording Wang Nan <wangnan0@huawei.com> - 2015-10-26 13:00 +0100
    Re: [RFC PATCH v2 1/2] perf tools: Set evsel->system_wide field for  global system wide recording Adrian Hunter <adrian.hunter@intel.com> - 2015-10-26 13:30 +0100
      Re: [RFC PATCH v2 1/2] perf tools: Set evsel->system_wide field for  global system wide recording "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-26 13:50 +0100
        Re: [RFC PATCH v2 1/2] perf tools: Set evsel->system_wide field for  global system wide recording Adrian Hunter <adrian.hunter@intel.com> - 2015-10-26 14:10 +0100
          Re: [RFC PATCH v2 1/2] perf tools: Set evsel->system_wide field for  global system wide recording "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-27 04:30 +0100

csiph-web