[PATCH] xen-blkback: clear PF_NOFREEZE for xen_blkif_schedule()

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	[PATCH] xen-blkback: clear PF_NOFREEZE for xen_blkif_schedule()
Date	2015-10-26 06:50 +0100
Message-ID	<qnIPn-4kh-1@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Jiri Kosina <jkosina@suse.cz>

xen_blkif_schedule() kthread calls try_to_freeze() at the beginning of 
every attempt to purge the LRU. This operation can't ever succeed though, 
as the kthread hasn't marked itself as freezable.

Before (hopefully eventually) kthread freezing gets converted to fileystem 
freezing, we'd rather mark xen_blkif_schedule() freezable (as it can 
generate I/O during suspend).

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 drivers/block/xen-blkback/blkback.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/block/xen-blkback/blkback.c b/drivers/block/xen-blkback/blkback.c
index af3caa3..bb65f7c 100644
--- a/drivers/block/xen-blkback/blkback.c
+++ b/drivers/block/xen-blkback/blkback.c
@@ -597,6 +597,7 @@ int xen_blkif_schedule(void *arg)
 
 	xen_blkif_get(blkif);
 
+	set_freezable();
 	while (!kthread_should_stop()) {
 		if (unlikely(vbd->size != vbd_sz(vbd)))
 			xen_vbd_resize(blkif);

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] xen-blkback: clear PF_NOFREEZE for xen_blkif_schedule() Jiri Kosina <jikos@kernel.org> - 2015-10-26 06:50 +0100

csiph-web