Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1255555

Re: [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name

From Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name
Date 2015-10-25 21:50 +0100
Message-ID <qnAoN-7Cc-7@gated-at.bofh.it> (permalink)
References <qnzM5-7oL-3@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hi Moritz,

On Sun, Oct 25, 2015 at 01:06:06PM -0700, Moritz Fischer wrote:
> The produced module will be called e3x0-button, not
> e3x0_button.

This is not entirely correct. The file name is e3x0-button.ko, but the
module name is e3x0_button: when we construct KBUILD_MODNAME we
substitute commas and dashes for underscores - see scripts/Makefile.lib

> 
> Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com>
> ---
>  drivers/input/misc/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/misc/Kconfig b/drivers/input/misc/Kconfig
> index 906dd1b..7ac277c7 100644
> --- a/drivers/input/misc/Kconfig
> +++ b/drivers/input/misc/Kconfig
> @@ -101,7 +101,7 @@ config INPUT_E3X0_BUTTON
>  	  USRP E3x0 Button.
>  
>  	  To compile this driver as a module, choose M here: the
> -	  module will be called e3x0_button.
> +	  module will be called e3x0-button.
>  
>  config INPUT_PCSPKR
>  	tristate "PC Speaker support"
> -- 
> 2.6.2
> 

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 1/2] input: misc: e3x0-button: Fix typo in module name Moritz Fischer <moritz.fischer@ettus.com> - 2015-10-25 21:10 +0100
  [PATCH 2/2] input: misc: e3x0-button: Update Kconfig description Moritz Fischer <moritz.fischer@ettus.com> - 2015-10-25 21:10 +0100
    Re: [PATCH 2/2] input: misc: e3x0-button: Update Kconfig description Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-25 22:00 +0100
  Re: [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2015-10-25 21:50 +0100
    Re: [PATCH 1/2] input: misc: e3x0-button: Fix typo in module name Moritz Fischer <moritz.fischer@ettus.com> - 2015-10-26 19:10 +0100

csiph-web