Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1255200

[PATCH 4/9] leds: 88pm860x: add missing of_node_put

Show all headers | View raw

for_each_child_of_node performs an of_node_get on each iteration, so
a break out of the loop requires an of_node_put.

A simplified version of the semantic patch that fixes this problem is as
follows (http://coccinelle.lip6.fr):

// <smpl>
@@
local idexpression n;
expression e,r;
@@

 for_each_child_of_node(r,n) {
   ...
(
   of_node_put(n);
|
   e = n
|
+  of_node_put(n);
?  break;
)
   ...
 }
... when != n
// </smpl>

Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>

---
 drivers/leds/leds-88pm860x.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/leds/leds-88pm860x.c b/drivers/leds/leds-88pm860x.c
index 1497a09..7870840 100644
--- a/drivers/leds/leds-88pm860x.c
+++ b/drivers/leds/leds-88pm860x.c
@@ -142,6 +142,7 @@ static int pm860x_led_dt_init(struct platform_device *pdev,
 			of_property_read_u32(np, "marvell,88pm860x-iset",
 					     &iset);
 			data->iset = PM8606_LED_CURRENT(iset);
+			of_node_put(np);
 			break;
 		}
 	}

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/9] add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-24 17:00 +0200
  [PATCH 4/9] leds: 88pm860x: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-24 17:00 +0200
  [PATCH 2/9] leds: bcm6358: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-24 17:00 +0200
  [PATCH 3/9] leds: bcm6328: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-24 17:00 +0200
  [PATCH 7/9] gpu: host1x: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-24 17:00 +0200
  [PATCH 8/9] soc: ti: knav_qmss_queue: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-24 17:00 +0200
  Re: [PATCH 0/9] add missing of_node_put Jacek Anaszewski <j.anaszewski@samsung.com> - 2015-10-26 09:50 +0100

csiph-web