Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254135

Re: [PATCH] staging: lustre: o2iblnd: fix misleading indentation

Show all headers | View raw

On Wed, Oct 21, 2015 at 06:40:40PM +0100, Luis de Bethencourt wrote:
> The code is correct, the indentation is misleading. Only the the return rc
> is part of the conditional statement if rc != 0.
> 
> Fix a smatch warning:
> drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd.c:2157
> kiblnd_hdev_setup_mrs() warn: curly braces intended?
> 
> Signed-off-by: Luis de Bethencourt <luisbg@osg.samsung.com>
> ---
> 
> Hi,
> 
> This patch gives a warning in checkpatch.pl for the line:
> if (hdev->ibh_mrs == NULL)
> 
> It would be cleaner if this was 'if (!hdev->ibh_mrs)' instead. I didn't fix
> this as well because the file has 41 instances of comparisons with NULL. I
> would be happy to do so in a patch in reply to this one if it would be good.
> 

You did the right thing.  One thing per patch.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] staging: lustre: o2iblnd: fix misleading indentation Luis de Bethencourt <luisbg@osg.samsung.com> - 2015-10-21 19:50 +0200
  Re: [PATCH] staging: lustre: o2iblnd: fix misleading indentation Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-22 21:50 +0200

csiph-web