Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254122
| From | Moritz Fischer <moritz.fischer@ettus.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [RFC] fpga: socfpga: Fix check of return value of devm_request_irq |
| Date | 2015-10-22 21:20 +0200 |
| Message-ID | <qmtz4-3kA-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
The return value should be checked for non-zero, instead of checking it being IS_ERR_VALUE(). Signed-off-by: Moritz Fischer <moritz.fischer@ettus.com> --- drivers/fpga/socfpga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/fpga/socfpga.c b/drivers/fpga/socfpga.c index 706b80d..27d2ff2 100644 --- a/drivers/fpga/socfpga.c +++ b/drivers/fpga/socfpga.c @@ -577,7 +577,7 @@ static int socfpga_fpga_probe(struct platform_device *pdev) ret = devm_request_irq(dev, priv->irq, socfpga_fpga_isr, 0, dev_name(dev), priv); - if (IS_ERR_VALUE(ret)) + if (ret) return ret; return fpga_mgr_register(dev, "Altera SOCFPGA FPGA Manager", -- 2.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
[RFC] fpga: socfpga: Fix check of return value of devm_request_irq Moritz Fischer <moritz.fischer@ettus.com> - 2015-10-22 21:20 +0200 Re: [RFC] fpga: socfpga: Fix check of return value of devm_request_irq Josh Cartwright <joshc@eso.teric.us> - 2015-10-25 11:10 +0100
csiph-web