Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253941

Re: [PATCH 1/2] perf tools: Setup pager when printing usage and help

Show all headers | View raw

On Thu, Oct 22, 2015 at 11:41 PM, Arnaldo Carvalho de Melo
<acme@kernel.org> wrote:
> Em Thu, Oct 22, 2015 at 11:28:31PM +0900, Namhyung Kim escreveu:
>> It's annoying to see error or help message when command has many options
>> like in perf record, report or top.  So setup pager when print parser
>> error or help message - it should be OK since no UI is enabled at the
>> parsing time.  The usage_with_options() already disables it by calling
>> exit_browser() anyway.
>
> But then we don't know what went wrong, try:
>
> [acme@zoo linux]$ perf record --all-cpus -g --42 --event cycles 2>&1 | head
>   Error: unknown option `42'
>
>  Usage: perf record [<options>] [<command>]
>     or: perf record [<options>] -- <command> [<options>]
>
>     -e, --event <event>   event selector. use 'perf list' to list
> available events
>         --filter <filter>
>                           event filter
>         --exclude-perf    don't record events from perf itself
>     -p, --pid <pid>       record events on existing process id
> [acme@zoo linux]$
>
> Without this patch I can see what was the option that caused the problem
> (--42 in this case), after the patch I can see only the valid options,
> not the one causing the problem, well, I can see it only if I use the
> same 2>&1 technique above.

Hmm.. some message are printed before calling usage_with_options() so
pager don't know about it.  Will check how to fix this..

Thanks,
Namhyung


>> Cc: Adrian Hunter <adrian.hunter@intel.com>
>> Cc: Borislav Petkov <bp@suse.de>
>> Cc: Brendan Gregg <brendan.d.gregg@gmail.com>
>> Cc: Chandler Carruth <chandlerc@gmail.com>
>> Cc: Frederic Weisbecker <fweisbec@gmail.com>
>> Cc: Stephane Eranian <eranian@google.com>
>> Cc: Wang Nan <wangnan0@huawei.com>
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
>> ---
>>  tools/perf/util/parse-options.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/tools/perf/util/parse-options.c b/tools/perf/util/parse-options.c
>> index 8aa7922397a9..388d385df5ad 100644
>> --- a/tools/perf/util/parse-options.c
>> +++ b/tools/perf/util/parse-options.c
>> @@ -648,6 +648,8 @@ int usage_with_options_internal(const char * const *usagestr,
>>       if (!usagestr)
>>               return PARSE_OPT_HELP;
>>
>> +     setup_pager();
>> +
>>       fprintf(stderr, "\n Usage: %s\n", *usagestr++);
>>       while (*usagestr && **usagestr)
>>               fprintf(stderr, "    or: %s\n", *usagestr++);
>> --
>> 2.6.0
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 1/2] perf tools: Setup pager when printing usage and help Namhyung Kim <namhyung@kernel.org> - 2015-10-22 16:30 +0200
  [PATCH 2/2] perf tools: Improve call graph documents and help messages Namhyung Kim <namhyung@kernel.org> - 2015-10-22 16:30 +0200
    Re: [PATCH 2/2] perf tools: Improve call graph documents and help  messages Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 16:50 +0200
      Re: [PATCH 2/2] perf tools: Improve call graph documents and help messages Namhyung Kim <namhyung@kernel.org> - 2015-10-22 18:10 +0200
        Re: [PATCH 2/2] perf tools: Improve call graph documents and help  messages Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 18:30 +0200
    Re: [PATCH 2/2] perf tools: Improve call graph documents and help  messages Frederic Weisbecker <fweisbec@gmail.com> - 2015-10-22 18:30 +0200
    Re: [PATCH 2/2] perf tools: Improve call graph documents and help  messages Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 20:40 +0200
    [tip:perf/core] perf tools:   Improve call graph documents and help messages tip-bot for Namhyung Kim <tipbot@zytor.com> - 2015-10-23 10:40 +0200
      Re: [tip:perf/core] perf tools: Improve call graph documents and  help messages Ingo Molnar <mingo@kernel.org> - 2015-10-23 11:10 +0200
        Re: [tip:perf/core] perf tools: Improve call graph documents and help messages Namhyung Kim <namhyung@kernel.org> - 2015-10-24 18:00 +0200
          Re: [tip:perf/core] perf tools: Improve call graph documents and  help messages Ingo Molnar <mingo@kernel.org> - 2015-10-25 10:20 +0100
  Re: [PATCH 1/2] perf tools: Setup pager when printing usage and help Arnaldo Carvalho de Melo <acme@kernel.org> - 2015-10-22 16:50 +0200
    Re: [PATCH 1/2] perf tools: Setup pager when printing usage and help Namhyung Kim <namhyung@kernel.org> - 2015-10-22 18:00 +0200

csiph-web