Re: [PATCH 4/5] block: introduce file_bd_inode()

From	Dan Williams <dan.j.williams@intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] block: introduce file_bd_inode()
Date	2015-10-22 17:50 +0200
Message-ID	<qmqhP-6SK-3@gated-at.bofh.it> (permalink)
References	<qmhRf-2Ly-17@gated-at.bofh.it> <qmhRg-2Ly-25@gated-at.bofh.it> <qmkFs-6UJ-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Oct 22, 2015 at 2:45 AM, Jan Kara <jack@suse.cz> wrote:
> On Thu 22-10-15 02:42:05, Dan Williams wrote:
>> Similar to the file_inode() helper, provide a helper to lookup the inode for a
>> raw block device itself.
>
> So I somewhat dislike the name file_bd_inode() since for struct file
> pointing to a regular file, the result would be equivalent to file_inode()
> but the name suggests (at least to me) it should return block device inode.
> I'd name it like bdev_file_inode() to make it clear this is local to
> block device code...

I like it, will fix.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 4/5] block: introduce file_bd_inode() Dan Williams <dan.j.williams@intel.com> - 2015-10-22 08:50 +0200
  Re: [PATCH 4/5] block: introduce file_bd_inode() Jan Kara <jack@suse.cz> - 2015-10-22 11:50 +0200
    Re: [PATCH 4/5] block: introduce file_bd_inode() Dan Williams <dan.j.williams@intel.com> - 2015-10-22 17:50 +0200

csiph-web