Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1253850

Re: [PATCH] VSOCK: sock_put wasn't safe to call in interrupt context

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH] VSOCK: sock_put wasn't safe to call in interrupt context
Date 2015-10-22 16:10 +0200
Message-ID <qmoJ5-4Fr-41@gated-at.bofh.it> (permalink)
References <qm0dI-22V-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: Jorgen Hansen <jhansen@vmware.com>
Date: Wed, 21 Oct 2015 04:53:56 -0700

> In the vsock vmci_transport driver, sock_put wasn't safe to call
> in interrupt context, since that may call the vsock destructor
> which in turn calls several functions that should only be called
> from process context. This change defers the callling of these
> functions  to a worker thread. All these functions were
> deallocation of resources related to the transport itself.
> 
> Furthermore, an unused callback was removed to simplify the
> cleanup.
> 
> Multiple customers have been hitting this issue when using
> VMware tools on vSphere 2015.
> 
> Also added a version to the vmci transport module (starting from
> 1.0.2.0-k since up until now it appears that this module was
> sharing version with vsock that is currently at 1.0.1.0-k).
> 
> Reviewed-by: Aditya Asarwade <asarwade@vmware.com>
> Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>
> Signed-off-by: Jorgen Hansen <jhansen@vmware.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

[PATCH] VSOCK: sock_put wasn't safe to call in interrupt context Jorgen Hansen <jhansen@vmware.com> - 2015-10-21 14:00 +0200
  Re: [PATCH] VSOCK: sock_put wasn't safe to call in interrupt  context David Miller <davem@davemloft.net> - 2015-10-22 16:10 +0200

csiph-web