Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1253788
| From | Wolfram Sang <wsa@the-dreams.de> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer |
| Date | 2015-10-22 15:10 +0200 |
| Message-ID | <qmnMZ-3jD-7@gated-at.bofh.it> (permalink) |
| References | <qm1Wa-4CG-17@gated-at.bofh.it> <qm1Wc-4CG-45@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Wed, Oct 21, 2015 at 03:44:04PM +0200, Ludovic Desroches wrote:
> In some cases, we could start a new i2c transfer with the RXRDY flag
> set. It is not a clean state and it leads to print annoying error
> messages even if there no real issue. The cause is only having garbage
> data in the Receive Holding Register because of a weird behavior of the
> RXRDY flag.
>
> Signed-off-by: Ludovic Desroches <ludovic.desroches@atmel.com>
> Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA
> controller")
> Reported-by: Peter Rosin <peda@lysator.liu.se>
> Tested-by: Peter Rosin <peda@lysator.liu.se>
> Cc: stable@vger.kernel.org #4.1
SMATCH
drivers/i2c/busses/i2c-at91.c:602 at91_do_twi_transfer warn: unused return: sr = at91_twi_read()
drivers/i2c/busses/i2c-at91.c: In function 'at91_do_twi_transfer':
drivers/i2c/busses/i2c-at91.c:550:11: warning: variable 'sr' set but not used [-Wunused-but-set-variable]
unsigned sr;
^
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 1/2] i2c: at91: fix write transfers by clearing pending interrupt first Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-10-21 15:50 +0200
[PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-10-21 15:50 +0200
Re: [PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer Wolfram Sang <wsa@the-dreams.de> - 2015-10-22 15:10 +0200
[PATCH v3] i2c: at91: manage unexpected RXRDY flag when starting a transfer Ludovic Desroches <ludovic.desroches@atmel.com> - 2015-10-26 10:40 +0100
Re: [PATCH v3] i2c: at91: manage unexpected RXRDY flag when starting a transfer Wolfram Sang <wsa@the-dreams.de> - 2015-10-26 15:50 +0100
Re: [PATCH v2 1/2] i2c: at91: fix write transfers by clearing pending interrupt first Wolfram Sang <wsa@the-dreams.de> - 2015-10-22 15:10 +0200
csiph-web