Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration

From	Eric Auger <eric.auger@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration
Date	2015-10-22 14:00 +0200
Message-ID	<qmmHg-1w5-3@gated-at.bofh.it> (permalink)
References	<qmkFs-6UJ-7@gated-at.bofh.it> <qmkFs-6UJ-27@gated-at.bofh.it> <qml8w-7Jh-27@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 10/22/2015 12:13 PM, Arnd Bergmann wrote:
> On Thursday 22 October 2015 11:41:59 Eric Auger wrote:
>> This patch adds the reset function registration/unregistration.
>>
>> Signed-off-by: Eric Auger <eric.auger@linaro.org>
> 
> Looks good, except one thing:
>> @@ -70,6 +69,8 @@ int vfio_platform_calxedaxgmac_reset(struct vfio_platform_device *vdev)
>>  			return -ENOMEM;
>>  	}
>>  
>> +	pr_info("VFIO reset of %s\n", vdev->name);
>> +
>>  	/* disable IRQ */
>>  	writel(0, reg.ioaddr + XGMAC_DMA_INTR_ENA);
>>  
> 
> This probably slipped in from debugging, please remove it.
Well actually this is not an oversight but some unappropriate tracing
attempt I am afraid. I wanted to add a trace useful for the end-user to
make sure the VFIO reset function was called. Do you forbid that or do
recommend to use another tracing mechanism/level? In the past I tried
dynamic tracing but with module loading mechanism I found it not that handy.

Eric
> 
> 	Arnd
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration Eric Auger <eric.auger@linaro.org> - 2015-10-22 11:50 +0200
  Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration Arnd Bergmann <arnd@arndb.de> - 2015-10-22 12:20 +0200
    Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset  function registration Eric Auger <eric.auger@linaro.org> - 2015-10-22 14:00 +0200
      Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset function registration Arnd Bergmann <arnd@arndb.de> - 2015-10-22 14:20 +0200
        Re: [PATCH v2 3/6] vfio: platform: reset: calxedaxgmac: add reset  function registration Eric Auger <eric.auger@linaro.org> - 2015-10-22 14:30 +0200

csiph-web