Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253698

Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release

Show all headers | View raw

On Thursday 22 October 2015 11:42:02 Eric Auger wrote:
> Currently reset lookup is done on probe. This introduces a
> race with new registration mechanism in the case where the
> vfio-platform driver is bound to the device before its module
> is loaded: on the load, the probe happens which triggers the
> reset module load which itself attempts to get the symbol for
> the registration function (vfio_platform_register_reset). The
> symbol is not yet available hence the lookup fails. In case we
> do the lookup in the first open we are sure the vfio-platform
> module is loaded and vfio_platform_register_reset is available.
> 
> Signed-off-by: Eric Auger <eric.auger@linaro.org>

I don't understand the explanation. I would expect the request_module()
call to block until the module is actually loaded. Is this not
what happens?

>         mutex_unlock(&driver_lock);
> @@ -181,6 +182,8 @@ static int vfio_platform_open(void *device_data)
>                 if (ret)
>                         goto err_irq;
>  
> +               vfio_platform_get_reset(vdev);
> +
>                 if (vdev->reset)
>                         vdev->reset(vdev);
> 

This needs some error handling to ensure that the open() fails
if there is no reset handler.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v2 6/6] vfio: platform: move get/put reset at open/release Eric Auger <eric.auger@linaro.org> - 2015-10-22 11:50 +0200
  Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release Arnd Bergmann <arnd@arndb.de> - 2015-10-22 12:30 +0200
    Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release Eric Auger <eric.auger@linaro.org> - 2015-10-22 13:50 +0200
      Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release Arnd Bergmann <arnd@arndb.de> - 2015-10-22 14:10 +0200
        Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release Eric Auger <eric.auger@linaro.org> - 2015-10-22 14:30 +0200
    Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release Eric Auger <eric.auger@linaro.org> - 2015-10-22 15:30 +0200
      Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release Arnd Bergmann <arnd@arndb.de> - 2015-10-22 16:20 +0200
        Re: [PATCH v2 6/6] vfio: platform: move get/put reset at open/release Eric Auger <eric.auger@linaro.org> - 2015-10-22 16:30 +0200
          Re: [PATCH v2 6/6] vfio: platform: move get/put reset at  open/release Alex Williamson <alex.williamson@redhat.com> - 2015-10-22 17:50 +0200

csiph-web