[PATCH v4 04/10] nfc: nci: Do not call post_setup when setup fails

From	Robert Dolca <robert.dolca@intel.com>
Newsgroups	linux.kernel
Subject	[PATCH v4 04/10] nfc: nci: Do not call post_setup when setup fails
Date	2015-10-22 11:20 +0200
Message-ID	<qmkcr-6lH-47@gated-at.bofh.it> (permalink)
References	<qmkcp-6lH-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

The driver should know that it can continue with post setup where
setup left off. Being able to execute post_setup when setup fails may
force the developer to keep this state in the driver.

Signed-off-by: Robert Dolca <robert.dolca@intel.com>
---
 net/nfc/nci/core.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/nfc/nci/core.c b/net/nfc/nci/core.c
index 0909720..5362d8f 100644
--- a/net/nfc/nci/core.c
+++ b/net/nfc/nci/core.c
@@ -402,9 +402,8 @@ static int nci_open_device(struct nci_dev *ndev)
 				   msecs_to_jiffies(NCI_INIT_TIMEOUT));
 	}
 
-	if (ndev->ops->post_setup) {
+	if (!rc && ndev->ops->post_setup)
 		rc = ndev->ops->post_setup(ndev);
-	}
 
 	if (!rc) {
 		rc = __nci_request(ndev, nci_init_complete_req, 0,
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH v4 04/10] nfc: nci: Do not call post_setup when setup fails Robert Dolca <robert.dolca@intel.com> - 2015-10-22 11:20 +0200

csiph-web