Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253565

Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat

Show all headers | View raw

On 10/21/2015 06:14 PM, Andrew Lunn wrote:
> On Wed, Oct 21, 2015 at 05:37:45PM +0200, Neil Armstrong wrote:
>> Like the change made for mv88e6xxx, use mutex_lock_nested() to avoid
>> lockdep to give false positives because of nested MDIO busses.
> 
> Hi Neil
> 
> We now have three instances of this, since mdio-mux.c has the same
> code. Maybe now would be a good time to refactor this code into
> mdiobus_read_nested() and mdiobus_write_nested() in mdio_bus.c?  At
> the same time, add BUG_ON(in_interrupt()) similar to the non-nested
> versions?
> 
> 	Andrew
> 
Well, mdio-mux also calls switch_fn inside the mdio_lock, clean refactoring
would introduce a separate lock and call the nested variants.
Is that ok ? Can someone test mdio-mux is I make the change ?


Neil
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat Neil Armstrong <narmstrong@baylibre.com> - 2015-10-21 17:40 +0200
  Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat Andrew Lunn <andrew@lunn.ch> - 2015-10-21 18:20 +0200
    Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat Neil Armstrong <narmstrong@baylibre.com> - 2015-10-22 09:40 +0200
    Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat Neil Armstrong <narmstrong@baylibre.com> - 2015-10-22 10:10 +0200
    Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat Neil Armstrong <narmstrong@baylibre.com> - 2015-10-22 10:10 +0200
      Re: [PATCH] net: dsa: mv88e6060: Fix false positive lockdep splat Andrew Lunn <andrew@lunn.ch> - 2015-10-22 14:10 +0200

csiph-web