Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253442

Re: [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board oscillator

Show all headers | View raw

On Tue, Oct 20, 2015 at 07:57:53PM +0300, Georgi Djakov wrote:
> Add the on-board XO oscillator. This patch prepares for adding support
> for RPM controlled clocks. In order to do smooth transition and support
> both cases (RPM clock driver is enabled or nor), we first move the XO to
> the DT and change the GCC fixed-rate root clock to a dummy pass-through
> clock. Then if the RPM driver is enabled, we set the parent of the XO
> clock in the RPM clock driver to xo_board.
> The advantage of doing so is that the rate of the XO clock is not hard-
> coded in the GCC driver anymore, but comes from the board layout, so
> that is why it should be in DT anyway.
> 
> Signed-off-by: Georgi Djakov <georgi.djakov@linaro.org>
> ---

Looks good to me.

Reviewed-by: Andy Gross <agross@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH v3 0/8] Add initial support for RPM clocks Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:00 +0200
  [PATCH v3 2/8] clk: qcom: msm8916: Set the parent of xo to xo_board Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:00 +0200
    Re: [PATCH v3 2/8] clk: qcom: msm8916: Set the parent of xo to  xo_board Stephen Boyd <sboyd@codeaurora.org> - 2015-10-26 23:50 +0100
  [PATCH v3 8/8] clk: qcom: msm8916: Remove hard-coded sleep_clk_src Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:00 +0200
  [PATCH v3 6/8] clk: qcom: Add RPM clock controller driver Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:00 +0200
    Re: [PATCH v3 6/8] clk: qcom: Add RPM clock controller driver Stephen Boyd <sboyd@codeaurora.org> - 2015-10-28 00:30 +0100
  [PATCH v3 5/8] clk: qcom: Add support for RPM Clocks Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:10 +0200
    Re: [PATCH v3 5/8] clk: qcom: Add support for RPM Clocks Stephen Boyd <sboyd@codeaurora.org> - 2015-10-28 00:20 +0100
  [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board oscillator Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:10 +0200
    Re: [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board  oscillator Andy Gross <agross@codeaurora.org> - 2015-10-22 05:00 +0200
    Re: [PATCH v3 1/8] arm64: dts: qcom: 8x16: Add fixed rate on-board  oscillator Stephen Boyd <sboyd@codeaurora.org> - 2015-10-28 00:20 +0100
  [PATCH v3 4/8] arm64: dts: qcom: 8x16: Add fixed rate sleep clock oscillator Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:10 +0200
  [PATCH v3 3/8] clk: qcom: msm8916: Ignore sleep_clk_src registration errors Georgi Djakov <georgi.djakov@linaro.org> - 2015-10-20 19:10 +0200
    Re: [PATCH v3 3/8] clk: qcom: msm8916: Ignore sleep_clk_src  registration errors Stephen Boyd <sboyd@codeaurora.org> - 2015-10-26 23:50 +0100

csiph-web