Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253380

Re: [PATCH -next] net: hisilicon: Never build on SPARC

Show all headers | View raw

From: Guenter Roeck <linux@roeck-us.net>
Date: Wed, 21 Oct 2015 10:03:05 -0700

> On 10/21/2015 08:57 AM, Arnd Bergmann wrote:
>> On Wednesday 21 October 2015 08:33:11 David Miller wrote:
>>> From: Guenter Roeck <linux@roeck-us.net>
>>> Date: Wed, 21 Oct 2015 07:56:18 -0700
>>>
>>>>> @@ -57,6 +57,11 @@ extern int of_dma_get_range(struct device_node *np,
>>>>> u64 *dma_addr,
>>>>>                               u64 *paddr, u64 *size);
>>>>>    extern bool of_dma_is_coherent(struct device_node *np);
>>>>>    #else /* CONFIG_OF_ADDRESS */
>>>>> +static inline u64 of_translate_address(struct device_node *np, const
>>>>> __be32 *addr)
>>>>> +{
>>>>> +    return 0;
>>>>
>>>> Maybe return OF_BAD_ADDR ?
>>>
>>> The thing to really do on sparc, is just return the address raw
>>> untranslated
>>> because that just works.
>>>
>>
>> We still need to check #address-cells, right?
>>
>> Something like this?
>>
>> static inline u64 of_translate_address(struct device_node *np, const
>> __be32 *addr)
>> {
>> #if defined(CONFIG_SPARC) || defined(CONFIG_M68K)
>> 	int pna = of_n_addr_cells(np);
>> 	u64 ret = be32_to_cpu(addr[pna - 1]);
>>
>> 	if (pna > 1)
>> 		ret += (u64)be32_to_cpu(addr[pna - 2]) << 32;
>>
>> 	return ret;
> 
> That suggests that sparc would need a translation after all, which
> seems to contradict what David said earlier.

It's not being translated, the code above is just figuring out what size
the object in the property is.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH -next] net: hisilicon: Never build on SPARC Guenter Roeck <linux@roeck-us.net> - 2015-10-21 16:30 +0200
  Re: [PATCH -next] net: hisilicon: Never build on SPARC Arnd Bergmann <arnd@arndb.de> - 2015-10-21 16:40 +0200
    Re: [PATCH -next] net: hisilicon: Never build on SPARC Guenter Roeck <linux@roeck-us.net> - 2015-10-21 17:00 +0200
      Re: [PATCH -next] net: hisilicon: Never build on SPARC David Miller <davem@davemloft.net> - 2015-10-21 17:20 +0200
        Re: [PATCH -next] net: hisilicon: Never build on SPARC Arnd Bergmann <arnd@arndb.de> - 2015-10-21 18:00 +0200
          Re: [PATCH -next] net: hisilicon: Never build on SPARC Guenter Roeck <linux@roeck-us.net> - 2015-10-21 19:10 +0200
            Re: [PATCH -next] net: hisilicon: Never build on SPARC Arnd Bergmann <arnd@arndb.de> - 2015-10-21 21:20 +0200
              Re: [PATCH -next] net: hisilicon: Never build on SPARC Guenter Roeck <linux@roeck-us.net> - 2015-10-22 00:00 +0200
            Re: [PATCH -next] net: hisilicon: Never build on SPARC David Miller <davem@davemloft.net> - 2015-10-22 03:10 +0200
    Re: [PATCH -next] net: hisilicon: Never build on SPARC David Miller <davem@davemloft.net> - 2015-10-21 17:20 +0200
  Re: [PATCH -next] net: hisilicon: Never build on SPARC David Miller <davem@davemloft.net> - 2015-10-21 17:20 +0200

csiph-web