Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in call trace

From	libin <huawei.libin@huawei.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in call trace
Date	2015-10-22 03:00 +0200
Message-ID	<qmcoy-2Xf-1@gated-at.bofh.it> (permalink)
References	<qjPFL-68P-13@gated-at.bofh.it> <qjQ8N-6Gn-3@gated-at.bofh.it> <qjQit-6RK-9@gated-at.bofh.it> <qjRxU-pn-9@gated-at.bofh.it> <qlHb6-7U3-51@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw


在 2015/10/20 23:32, Catalin Marinas 写道:
> On Thu, Oct 15, 2015 at 10:18:12AM -0400, Steven Rostedt wrote:
>> On Thu, 15 Oct 2015 13:51:33 +0100
>> Will Deacon <will.deacon@arm.com> wrote:
>>
>>> Is this the same old problem caused by e306dfd06fcb ("ARM64: unwind: Fix
>>> PC calculation")? I've said previously that I'm happy to revert that if
>>> we're the only architecture with this behaviour, but Akashi resisted
>>> because there are other issues with ftrace that he was hoping to address
>>> and they would resolve this too.
>>
>> Just a reference, but this patch is pretty much exactly what x86
>> currently has. I wonder if I should make that function generic for all
>> archs to use.
>>
>> If you accept this patch, I can look at what archs do and pull out the
>> common code and place it into the core code and have the archs call
>> that instead.
>
> The difference I see from the sh and x86 version is that we have this -4
> on arm64, introduced by e306dfd06fcb as Will mentioned above (it seemed
> to have caused more problems that it solved). I think we should revert
> that commit first just to be in line with other architectures and then
> apply additional fixes as needed.
>
> Question for Li Bin: is your patch still needed if we revert commit
> e306dfd06fcb?
>

It still be needed, but it can be implemented in generic for all archs
as Steve suggested.

Thanks,
Li Bin

> Thanks.
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in  call trace Catalin Marinas <catalin.marinas@arm.com> - 2015-10-20 17:40 +0200
  Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in  call trace libin <huawei.libin@huawei.com> - 2015-10-22 03:00 +0200
    Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in  call trace Steven Rostedt <rostedt@goodmis.org> - 2015-10-22 03:20 +0200
    Re: [PATCH] arm64: ftrace: function_graph: dump real return addr in  call trace Will Deacon <will.deacon@arm.com> - 2015-10-28 16:30 +0100

csiph-web