Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253372

[PATCH block/for-4.4/core] blkcg: don't create "io.stat" on the root cgroup

Show all headers | View raw

Hello, Jens.

This is one of hopefully final adjustments to cgroup v2 behavior
before lifting the devel mask.  If the patch is okay, can I route the
patch through cgroup/for-4.4 so that it can go together with the
cgroup documentation update patch?

Thanks.

------ 8< ------
The stat files on the root cgroup shows stats for the whole system and
usually don't contain any information which isn't available through
the usual system monitoring mechanisms.  Some controllers skip
collecting these duplicate stats to optimize cases where cgroup isn't
used and later try to emulate the result on demand.

This leads to complexities and subtle differences in the information
shown through different channels.  This is entirely unnecessary and
cgroup v2 is dropping stat files which are duplicate from all
controllers.  This patch removes "io.stat" from the root hierarchy.

Signed-off-by: Tejun Heo <tj@kernel.org>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Vivek Goyal <vgoyal@redhat.com>
---
 block/blk-cgroup.c |    1 +
 1 file changed, 1 insertion(+)

--- a/block/blk-cgroup.c
+++ b/block/blk-cgroup.c
@@ -896,6 +896,7 @@ static int blkcg_print_stat(struct seq_f
 struct cftype blkcg_files[] = {
 	{
 		.name = "stat",
+		.flags = CFTYPE_NOT_ON_ROOT,
 		.seq_show = blkcg_print_stat,
 	},
 	{ }	/* terminate */
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH block/for-4.4/core] blkcg: don't create "io.stat" on the root  cgroup Tejun Heo <tj@kernel.org> - 2015-10-22 02:40 +0200
  Re: [PATCH block/for-4.4/core] blkcg: don't create "io.stat" on the  root cgroup Jens Axboe <axboe@kernel.dk> - 2015-10-22 06:10 +0200
    Re: [PATCH block/for-4.4/core] blkcg: don't create "io.stat" on the  root cgroup Tejun Heo <tj@kernel.org> - 2015-10-22 11:10 +0200

csiph-web