Re: [PATCH 5/5] clk: scpi: add missing of_node_put

Path	csiph.com!eternal-september.org!feeder.eternal-september.org!aioe.org!bofh.it!news.nic.it!robomod
From	Stephen Boyd <sboyd@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 5/5] clk: scpi: add missing of_node_put
Date	Thu, 22 Oct 2015 01:20:02 +0200
Message-ID	<qmaPM-R6-13@gated-at.bofh.it> (permalink)
References	<qm8Ei-5ZO-7@gated-at.bofh.it> <qm8Ej-5ZO-25@gated-at.bofh.it>
X-Original-To	Julia Lawall <Julia.Lawall@lip6.fr>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	40
Organization	linux.* mail to news gateway
X-Original-Cc	Sudeep Holla <sudeep.holla@arm.com>, kernel-janitors@vger.kernel.org, Michael Turquette <mturquette@baylibre.com>, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Russell King - ARM Linux <linux@arm.linux.org.uk>, Thomas Petazzoni <thomas.petazzoni@free-electrons.com>, Andrew Lunn <andrew@lunn.ch>, Bjorn Helgaas <bhelgaas@google.com>, Jason Cooper <jason@lakedaemon.net>
X-Original-Date	Wed, 21 Oct 2015 16:17:12 -0700
X-Original-Message-ID	<20151021231712.GL19782@codeaurora.org>
X-Original-References	<1445460100-26727-1-git-send-email-Julia.Lawall@lip6.fr> <1445460100-26727-6-git-send-email-Julia.Lawall@lip6.fr>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1253343

Show key headers only | View raw

On 10/21, Julia Lawall wrote:
> for_each_available_child_of_node performs an of_node_get on each iteration,
> so a break out of the loop requires an of_node_put.
> 
> The semantic patch that fixes this problem is as follows
> (http://coccinelle.lip6.fr):
> 
> // <smpl>
> @@
> expression root,e;
> local idexpression child;
> @@
> 
>  for_each_available_child_of_node(root, child) {
>    ... when != of_node_put(child)
>        when != e = child
> (
>    return child;
> |
> +  of_node_put(child);
> ?  return ...;
> )
>    ...
>  }
> // </smpl>
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
> 
> ---

Acked-by: Stephen Boyd <sboyd@codeaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 5/5] clk: scpi: add missing of_node_put Julia Lawall <Julia.Lawall@lip6.fr> - 2015-10-21 23:00 +0200
  Re: [PATCH 5/5] clk: scpi: add missing of_node_put Stephen Boyd <sboyd@codeaurora.org> - 2015-10-22 01:20 +0200
  Re: [PATCH 5/5] clk: scpi: add missing of_node_put Sudeep Holla <sudeep.holla@arm.com> - 2015-10-22 11:30 +0200

csiph-web