Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback

From	Masahiro Yamada <yamada.masahiro@socionext.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback
Date	2015-10-24 06:10 +0200
Message-ID	<qmYjw-5U7-11@gated-at.bofh.it> (permalink)
References	<qmjq1-59y-13@gated-at.bofh.it> <qmJXd-1GX-29@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Peter,

2015-10-23 21:45 GMT+09:00 Peter Hurley <peter@hurleysoftware.com>:
> On 10/22/2015 04:21 AM, Masahiro Yamada wrote:
>> The IER has already been masked in early_serial8250_setup(), there is
>> no reason to save and restore it every time early_serial8250_write()
>> is called.
>>
>> Let wait_for_xmitr() melt into serial_putc().
>
> Both of these changes are ok with me, but please split this into
> 2 patches so reverting either one in case of regression is trivial.
>
> Regards,
> Peter Hurley


OK, will do.


-- 
Best Regards
Masahiro Yamada
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] serial: 8250_early: do not save and restore IER in write callback Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-22 10:30 +0200
  Re: [PATCH] serial: 8250_early: do not save and restore IER in write  callback Peter Hurley <peter@hurleysoftware.com> - 2015-10-23 14:50 +0200
    Re: [PATCH] serial: 8250_early: do not save and restore IER in write callback Masahiro Yamada <yamada.masahiro@socionext.com> - 2015-10-24 06:10 +0200

csiph-web