Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254960
| From | Austin S Hemmelgarn <ahferroin7@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v12 21/49] ext4: Add richacl feature flag |
| Date | 2015-10-23 21:40 +0200 |
| Message-ID | <qmQlY-2ya-15@gated-at.bofh.it> (permalink) |
| References | <qmPzA-1ob-3@gated-at.bofh.it> <qmPzC-1ob-69@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On 2015-10-23 14:41, Andreas Gruenbacher wrote:
> From: "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>
>
> This feature flag selects richacl instead of posix acl support on the
> file system. In addition, the "acl" mount option is needed for enabling
> either of the two kinds of acls.
>
> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.vnet.ibm.com>
> Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
> ---
> fs/ext4/ext4.h | 6 ++++--
> fs/ext4/super.c | 49 ++++++++++++++++++++++++++++++++++++++++---------
> 2 files changed, 44 insertions(+), 11 deletions(-)
>
> diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
> index fd1f28b..b97a3b1 100644
> --- a/fs/ext4/ext4.h
> +++ b/fs/ext4/ext4.h
> @@ -991,7 +991,7 @@ struct ext4_inode_info {
> #define EXT4_MOUNT_UPDATE_JOURNAL 0x01000 /* Update the journal format */
> #define EXT4_MOUNT_NO_UID32 0x02000 /* Disable 32-bit UIDs */
> #define EXT4_MOUNT_XATTR_USER 0x04000 /* Extended user attributes */
> -#define EXT4_MOUNT_POSIX_ACL 0x08000 /* POSIX Access Control Lists */
> +#define EXT4_MOUNT_ACL 0x08000 /* Access Control Lists */
> #define EXT4_MOUNT_NO_AUTO_DA_ALLOC 0x10000 /* No auto delalloc mapping */
> #define EXT4_MOUNT_BARRIER 0x20000 /* Use block barriers */
> #define EXT4_MOUNT_QUOTA 0x80000 /* Some quota option set */
> @@ -1582,6 +1582,7 @@ static inline int ext4_encrypted_inode(struct inode *inode)
> #define EXT4_FEATURE_INCOMPAT_LARGEDIR 0x4000 /* >2GB or 3-lvl htree */
> #define EXT4_FEATURE_INCOMPAT_INLINE_DATA 0x8000 /* data in inode */
> #define EXT4_FEATURE_INCOMPAT_ENCRYPT 0x10000
> +#define EXT4_FEATURE_INCOMPAT_RICHACL 0x20000
>
> #define EXT2_FEATURE_COMPAT_SUPP EXT4_FEATURE_COMPAT_EXT_ATTR
> #define EXT2_FEATURE_INCOMPAT_SUPP (EXT4_FEATURE_INCOMPAT_FILETYPE| \
> @@ -1607,7 +1608,8 @@ static inline int ext4_encrypted_inode(struct inode *inode)
> EXT4_FEATURE_INCOMPAT_FLEX_BG| \
> EXT4_FEATURE_INCOMPAT_MMP | \
> EXT4_FEATURE_INCOMPAT_INLINE_DATA | \
> - EXT4_FEATURE_INCOMPAT_ENCRYPT)
> + EXT4_FEATURE_INCOMPAT_ENCRYPT | \
> + EXT4_FEATURE_INCOMPAT_RICHACL)
If this is going to be an incompat feature, the reasoning for that being
the case should be clearly documented in either the changelog or the
code itself. While the people involved in the discussion of this may
understand the reasoning, that doesn't mean any arbitrary individual
will at some point in the future, and documenting it properly will save
time for people trying to figure out why this non-obvious choice was made.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v12 00/49] Richacls Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 04/49] vfs: Make the inode passed to inode_change_ok non-const Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 01/49] vfs: Add IS_ACL() and IS_RICHACL() tests Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 08/49] richacl: Compute maximum file masks from an acl Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 38/49] nfsd: Add support for the MAY_CREATE_{FILE,DIR} permissions Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 25/49] xfs: Add richacl support Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 09/49] richacl: Permission check algorithm Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 34/49] nfsd: Keep list of acls to dispose of in compoundargs Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 42/49] xfs: Don't allow unmapped identifiers in richacls Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 13/49] richacl: Update the file masks in chmod() Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 32/49] richacl: Apply the file masks to a richacl Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 28/49] richacl: Propagate everyone@ permissions to other aces Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 49/49] nfs: Add support for the v4.1 dacl attribute Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 41/49] ext4: Don't allow unmapped identifiers in richacls Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 33/49] richacl: Create richacl from mode values Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 03/49] vfs: Add MAY_DELETE_SELF and MAY_DELETE_CHILD permission flags Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 12/49] vfs: Cache richacl in struct inode Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 44/49] sunrpc: Add xdr_init_encode_pages Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 16/49] richacl: Automatic Inheritance Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 29/49] richacl: Set the owner permissions to the owner mask Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 17/49] richacl: xattr mapping functions Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 20/49] ext4: Add richacl support Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 06/49] richacl: In-memory representation and helper functions Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 45/49] nfs: Fix GETATTR bitmap verification Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 15/49] richacl: Create-time inheritance Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 48/49] nfs: Add richacl support Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 35/49] nfsd: Use richacls as internal acl representation Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 21/49] ext4: Add richacl feature flag Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
Re: [PATCH v12 21/49] ext4: Add richacl feature flag Austin S Hemmelgarn <ahferroin7@gmail.com> - 2015-10-23 21:40 +0200
[PATCH v12 47/49] nfs: Distinguish missing users and groups from nobody Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 24/49] xfs: Change how listxattr generates synthetic attributes Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 31/49] richacl: Isolate the owner and group classes Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 26/49] richacl: acl editing helper functions Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 02/49] vfs: Add MAY_CREATE_FILE and MAY_CREATE_DIR permission flags Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 05/49] vfs: Add permission flags for setting file attributes Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 19/49] vfs: Add richacl permission checking Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 14/49] richacl: Check if an acl is equivalent to a file mode Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 07/49] richacl: Permission mapping functions Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 40/49] nfsd: Add support for unmapped richace identifiers Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 11/49] vfs: Add get_richacl and set_richacl inode operations Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 39/49] richacl: Add support for unmapped identifiers Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 43/49] sunrpc: Allow to demand-allocate pages to encode into Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 37/49] nfsd: Add support for the v4.1 dacl attribute Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 20:50 +0200
[PATCH v12 36/49] nfsd: Add richacl support Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 21:00 +0200
[PATCH v12 27/49] richacl: Move everyone@ aces down the acl Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 21:10 +0200
[PATCH v12 30/49] richacl: Set the other permissions to the other mask Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 21:10 +0200
[PATCH v12 23/49] xfs: Make xfs_set_mode non-static Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 21:20 +0200
[PATCH v12 18/49] richacl: Add richacl xattr handler Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 21:20 +0200
[PATCH v12 22/49] xfs: Fix error path in xfs_get_acl Andreas Gruenbacher <agruenba@redhat.com> - 2015-10-23 21:20 +0200
RE: [PATCH v12 00/49] Richacls "Frank Filz" <ffilzlnx@mindspring.com> - 2015-10-23 22:20 +0200
csiph-web