Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254872
| From | Douglas Anderson <dianders@chromium.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at phy port reset |
| Date | 2015-10-23 20:30 +0200 |
| Message-ID | <qmPgf-112-45@gated-at.bofh.it> (permalink) |
| References | <qmPgd-112-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
The "host1" port (AKA the dwc2 port that isn't the OTG port) on rk3288 has a hardware errata that causes everything to get confused when we get a remote wakeup. It appears that the "port reset" bit that's in the USB phy (located in the rk3288 GRF) fixes things up and appears safe to do. We recently added code to the PHY to expose this reset and code to dwc2 to use it, so now let's hook things up. Note that we add the PHY port reset to both dwc2 controllers even though only one has the errata in case we find some other use for this reset that's unrelated to the current hardware errata. Only the host port gets the quirk property, though. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm/boot/dts/rk3288.dtsi | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 4f76805..03de41d 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -496,6 +496,9 @@ dr_mode = "host"; phys = <&usbphy2>; phy-names = "usb2-phy"; + resets = <&usbphy2>; + reset-names = "phy-port-reset"; + snps,need-phy-port-reset-on-wake; status = "disabled"; }; @@ -513,6 +516,8 @@ g-use-dma; phys = <&usbphy0>; phy-names = "usb2-phy"; + resets = <&usbphy0>; + reset-names = "phy-port-reset"; status = "disabled"; }; -- 2.6.0.rc2.230.g3dd15c0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port Douglas Anderson <dianders@chromium.org> - 2015-10-23 20:30 +0200
[PATCH 2/4] usb: dwc2: optionally assert phy "port reset" when waking up Douglas Anderson <dianders@chromium.org> - 2015-10-23 20:30 +0200
[PATCH 4/4] ARM: dts: rockchip: Point rk3288 dwc2 usb at phy port reset Douglas Anderson <dianders@chromium.org> - 2015-10-23 20:30 +0200
[PATCH 3/4] ARM: dts: rockchip: Enable the USB phys as reset providers on rk3288 Douglas Anderson <dianders@chromium.org> - 2015-10-23 20:30 +0200
Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port Heiko Stübner <heiko@sntech.de> - 2015-10-24 14:30 +0200
Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port Rob Herring <robh@kernel.org> - 2015-10-24 18:40 +0200
Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port Doug Anderson <dianders@chromium.org> - 2015-10-24 23:30 +0200
Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port Rob Herring <robh@kernel.org> - 2015-10-27 00:10 +0100
Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port Doug Anderson <dianders@chromium.org> - 2015-10-27 01:00 +0100
Re: [PATCH 0/4] Patches to fix remote wakeup on rk3288 dwc2 "host" port Doug Anderson <dianders@chromium.org> - 2015-10-27 02:50 +0100
csiph-web