Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254665

Re: [PATCH v4 2/3] thermal: rockchip: support the sleep pinctrl state to avoid glitches in s2r

Show all headers | View raw

Caesar,

On Fri, Oct 23, 2015 at 4:25 AM, Caesar Wang <wxt@rock-chips.com> wrote:
> When we come out of system suspend state (S3) the tsadc will have been
> reset and back at its default state.  While reprogramming the tsadc
> it's possible that we'll glitch the output and unintentionally cause
> the "over temperature" GPIO to be asserted.  Since the over
> temperature GPIO is often hooked up to something that will cause a
> reboot or shutdown in hardware, this glitch can be catastrophic on
> some boards.
>
> We'll add support for selecting the "sleep" pinctrl state at suspend
> time.  Boards can use this to effectively disable the tsadc at suspend
> time and avoid glitches when the system is resumed.
>
> Signed-off-by: Caesar Wang <wxt@rock-chips.com>
>
> ---
>
> Changes in v4:
>   - take the Doug's commit as correct decription.
>
> Changes in v3:
>   - Add the pinctrl state for in the suspend/resume.
>
> Changes in v2: None
> Changes in v1: None
>
>  drivers/thermal/rockchip_thermal.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] fix the TSHUT issue on rockchip thermal Caesar Wang <wxt@rock-chips.com> - 2015-10-23 13:30 +0200
  [PATCH v4 1/3] dt-bindings: rockchip-thermal: Add the pinctrl states in this document Caesar Wang <wxt@rock-chips.com> - 2015-10-23 13:30 +0200
    Re: [PATCH v4 1/3] dt-bindings: rockchip-thermal: Add the pinctrl  states in this document Rob Herring <robh+dt@kernel.org> - 2015-10-23 15:30 +0200
  [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl Caesar Wang <wxt@rock-chips.com> - 2015-10-23 13:30 +0200
    Re: [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl Doug Anderson <dianders@chromium.org> - 2015-10-23 17:30 +0200
      Re: [PATCH v4 3/3] ARM: dts: rockchip: Add the OTP gpio pinctrl Heiko Stübner <heiko@sntech.de> - 2015-10-25 09:00 +0100
  [PATCH v4 2/3] thermal: rockchip: support the sleep pinctrl state to avoid glitches in s2r Caesar Wang <wxt@rock-chips.com> - 2015-10-23 13:30 +0200
    Re: [PATCH v4 2/3] thermal: rockchip: support the sleep pinctrl state  to avoid glitches in s2r Doug Anderson <dianders@chromium.org> - 2015-10-23 17:30 +0200

csiph-web