Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254649
| From | Alexei Starovoitov <ast@plumgrid.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper |
| Date | 2015-10-23 16:50 +0200 |
| Message-ID | <qmLPj-4o0-3@gated-at.bofh.it> (permalink) |
| References | <qmyfn-1GK-7@gated-at.bofh.it> <qmJku-X9-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On 10/23/15 5:03 AM, Peter Zijlstra wrote: > So the bpf_perf_event_read() returns the count value, does this not also > mean that returning -EINVAL here is also 'wrong'? > > I mean, sure an actual count value that high is unlikely, but its still > a broken interface. Agree. that's not pretty interface. I wish I looked at it more carefully when it was introduced. Now it's too late to change. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov <ast@plumgrid.com> - 2015-10-23 02:20 +0200
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-23 04:30 +0200
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov <ast@plumgrid.com> - 2015-10-23 04:40 +0200
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-23 05:50 +0200
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Peter Zijlstra <peterz@infradead.org> - 2015-10-23 14:10 +0200
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov <ast@plumgrid.com> - 2015-10-23 16:50 +0200
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Peter Zijlstra <peterz@infradead.org> - 2015-10-23 17:00 +0200
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Ingo Molnar <mingo@kernel.org> - 2015-10-25 10:30 +0100
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov <ast@plumgrid.com> - 2015-10-25 17:30 +0100
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Peter Zijlstra <peterz@infradead.org> - 2015-10-26 13:40 +0100
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper "Wangnan (F)" <wangnan0@huawei.com> - 2015-10-26 14:00 +0100
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper Alexei Starovoitov <ast@plumgrid.com> - 2015-10-26 22:30 +0100
Re: [PATCH v3 net-next] bpf: fix bpf_perf_event_read() helper David Miller <davem@davemloft.net> - 2015-10-27 05:40 +0100
csiph-web