Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1254575

Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t

From David Miller <davem@davemloft.net>
Newsgroups linux.kernel
Subject Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t
Date 2015-10-23 15:00 +0200
Message-ID <qmK6S-1Sl-5@gated-at.bofh.it> (permalink)
References <qmJu9-18q-3@gated-at.bofh.it> <qmJub-18q-41@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


From: LABBE Corentin <clabbe.montjoie@gmail.com>
Date: Fri, 23 Oct 2015 14:10:35 +0200

> The hlen member of raw_frag_vec is used in operation/function that wait
> for unsigned value. So it need to be set as size_t.
> 
> Signed-off-by: LABBE Corentin <clabbe.montjoie@gmail.com>

You really need to test your changes.

Particularly on a platform where size_t has a different size than
'int'.  That will generate several warnings, as shown by all of the
build warning reports sent by the kbuild test robot in response to
this patch series.

Also, you need to CC: all relevant mailing lists for the entire series
of patches, and also provide a "Subject: [PATCH 0/N] xxx" posting
describing at a high level and in detail what this patch series is
doing, and why.

It should also clearly state what exact tree you expect these patches
to be merged into.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

(none) LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
  [PATCH 03/11] net: llc: change copied to size_t in llc_ui_sendmsg LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
  [PATCH 11/11] crypto: algif: Change some variable to size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
  [PATCH 02/11] net: llc: fix a setting of error value to size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
  [PATCH 08/11] net: bluetooth: change the len parameter of sco_send_frame() to size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
    Re: [PATCH 08/11] net: bluetooth: change the len parameter of sco_send_frame() to size_t Marcel Holtmann <marcel@holtmann.org> - 2015-10-25 21:00 +0100
  [PATCH 04/11] net: packet: change vnet_hdr_len from int to size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
    Re: [PATCH 04/11] net: packet: change vnet_hdr_len from int to size_t "Michael S. Tsirkin" <mst@redhat.com> - 2015-10-23 15:40 +0200
  [PATCH 07/11] net: caif: change chunk from int to size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
  [PATCH 10/11] net: ipv4: hlen could be set as size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
    Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t David Miller <davem@davemloft.net> - 2015-10-23 15:00 +0200
      Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 15:30 +0200
        Re: [PATCH 10/11] net: ipv4: hlen could be set as size_t David Miller <davem@davemloft.net> - 2015-10-23 15:40 +0200
  [PATCH 01/11] net: change len parameter type for memcpy_[to|from]_msg LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200
  [PATCH 09/11] net: ipv6: hlen could be set as size_t LABBE Corentin <clabbe.montjoie@gmail.com> - 2015-10-23 14:20 +0200

csiph-web