Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)

From	Nilesh Kokane <nilesh.kokane05@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN)
Date	2015-10-23 14:20 +0200
Message-ID	<qmJub-18q-29@gated-at.bofh.it> (permalink)
References	<qmCj0-7vn-1@gated-at.bofh.it> <qmJ18-lc-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 23, 2015 at 5:10 PM, Dilger, Andreas
<andreas.dilger@intel.com> wrote:
> On 2015/10/22, 22:30, "Nilesh Kokane" <nilesh.kokane05@gmail.com> wrote:
>>Fixed- Return of an errno should typically be negative (ie: return
>>-EAGAIN)
>
> Nak. Please do not change these function return values.  They are
> converted as necessary by the callers before returning to userspace, but
> allow the code to distinguish between errors generated internally or from
> lower networking layers.
>
> As you will note, many of them are explicitly annotated with comments that
> they are returning positive values.  The patch as it stands would totally
> break the code.

Ok. I'll take care next time.

-- 
//Nilesh Kokane
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno should typically be negative (ie: return -EAGAIN) Nilesh Kokane <nilesh.kokane05@gmail.com> - 2015-10-23 06:40 +0200
  Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno  should typically be negative (ie: return -EAGAIN) Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-23 07:10 +0200
    Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno  should typically be negative (ie: return -EAGAIN) Dan Carpenter <dan.carpenter@oracle.com> - 2015-10-23 08:50 +0200
  Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno  should typically be negative (ie: return -EAGAIN) "Dilger, Andreas" <andreas.dilger@intel.com> - 2015-10-23 13:50 +0200
    Re: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno  should typically be negative (ie: return -EAGAIN) Nilesh Kokane <nilesh.kokane05@gmail.com> - 2015-10-23 14:20 +0200
  RE: [PATCH 2/2] Staging: lustre: lnet: lib-move return of an errno  should typically be negative (ie: return -EAGAIN) "Simmons, James A." <simmonsja@ornl.gov> - 2015-10-23 17:20 +0200

csiph-web