Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1254469

[PATCH 3/6] drm/vc4: fix itnull.cocci warnings

Show all headers | View raw

From: Julia Lawall <julia.lawall@lip6.fr>

Connector cannot be null because it is a list entry, ie accessed at an
offset from the positions of the list structure pointers themselves.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Eric Anholt <eric@anholt.net>
---
 drivers/gpu/drm/vc4/vc4_crtc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c
index 8489d5b..a3a77dd 100644
--- a/drivers/gpu/drm/vc4/vc4_crtc.c
+++ b/drivers/gpu/drm/vc4/vc4_crtc.c
@@ -168,7 +168,7 @@ static int vc4_get_clock_select(struct drm_crtc *crtc)
 	struct drm_connector *connector;
 
 	drm_for_each_connector(connector, crtc->dev) {
-		if (connector && connector->state->crtc == crtc) {
+		if (connector->state->crtc == crtc) {
 			struct drm_encoder *encoder = connector->encoder;
 			struct vc4_encoder *vc4_encoder =
 				to_vc4_encoder(encoder);
-- 
2.6.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

VC4 fixes for -next Eric Anholt <eric@anholt.net> - 2015-10-23 12:40 +0200
  [PATCH 4/6] drm/vc4: Fix some failure to track __iomem decorations on pointers. Eric Anholt <eric@anholt.net> - 2015-10-23 12:40 +0200
    Re: [PATCH 4/6] drm/vc4: Fix some failure to track __iomem decorations on pointers. Eric Anholt <eric@anholt.net> - 2015-10-23 18:40 +0200
  [PATCH 6/6] drm/vc4: Add support for more a few more RGB display plane formats. Eric Anholt <eric@anholt.net> - 2015-10-23 12:40 +0200
  [PATCH 1/6] drm/vc4: vc4_plane_duplicate_state() can be static Eric Anholt <eric@anholt.net> - 2015-10-23 12:40 +0200
  [PATCH 3/6] drm/vc4: fix itnull.cocci warnings Eric Anholt <eric@anholt.net> - 2015-10-23 12:40 +0200
  [PATCH 5/6] drm/vc4: Make sure that planes aren't scaled. Eric Anholt <eric@anholt.net> - 2015-10-23 12:40 +0200
    Re: [PATCH 5/6] drm/vc4: Make sure that planes aren't scaled. Daniel Vetter <daniel@ffwll.ch> - 2015-10-23 13:30 +0200
  [PATCH 2/6] drm/vc4: fix platform_no_drv_owner.cocci warnings Eric Anholt <eric@anholt.net> - 2015-10-23 12:40 +0200

csiph-web