Re: [PATCH V2 2/3] Add iommu driver for hi6220 SoC platform

From	chenfeng <puck.chen@hisilicon.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH V2 2/3] Add iommu driver for hi6220 SoC platform
Date	2015-10-23 11:20 +0200
Message-ID	<qmGFZ-5oJ-29@gated-at.bofh.it> (permalink)
References	<qlAMj-6Wk-45@gated-at.bofh.it> <qlAMj-6Wk-43@gated-at.bofh.it> <qlGI2-7mo-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Robin,

On 2015/10/20 23:02, Robin Murphy wrote:
> On 20/10/15 09:45, Chen Feng wrote:
>> iommu/hisilicon: Add hi6220-SoC smmu driver
> 

>> +
>> +static int hi6220_smmu_attach_dev(struct iommu_domain *domain,
>> +                  struct device *dev)
>> +{
>> +    dev->archdata.iommu = &iova_allocator;
> 
> If the hardware doesn't offer any kind of device isolation (i.e. multiple translation contexts), then you should probably have more logic here to ensure only a single domain can ever be active at once.
> 
>> +    return 0;
>> +}
>> +
I feel confused about your above comments. Could you help explain "ensure only a single domain can ever be active at once"?


> Robin.
> 
> 
> .
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH V2 2/3] Add iommu driver for hi6220 SoC platform Chen Feng <puck.chen@hisilicon.com> - 2015-10-20 10:50 +0200
  Re: [PATCH V2 2/3] Add iommu driver for hi6220 SoC platform Robin Murphy <robin.murphy@arm.com> - 2015-10-20 17:10 +0200
    Re: [PATCH V2 2/3] Add iommu driver for hi6220 SoC platform chenfeng <puck.chen@hisilicon.com> - 2015-10-21 04:10 +0200
    Re: [PATCH V2 2/3] Add iommu driver for hi6220 SoC platform chenfeng <puck.chen@hisilicon.com> - 2015-10-23 11:20 +0200

csiph-web