Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1254339
| From | Mike Looijmans <mike.looijmans@topic.nl> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] pinctrl-zynq: Initialize early |
| Date | 2015-10-23 07:40 +0200 |
| Message-ID | <qmDf4-pc-13@gated-at.bofh.it> (permalink) |
| References | <qmmnT-18n-9@gated-at.bofh.it> <qmDf4-pc-15@gated-at.bofh.it> |
| Organization | TOPIC |
On 22-10-15 18:07, Sören Brinkmann wrote: > Hi Mike, > > On Thu, 2015-10-22 at 01:30PM +0200, Mike Looijmans wrote: >> Supplying pinmux configuration for e.g. gpio pins leads to deferred >> probes because the pinctrl device is probed much later than gpio. >> Move the init call to a much earlier stage so it probes before the >> devices that may need it. >> >> Signed-off-by: Mike Looijmans <mike.looijmans@topic.nl> > > in general, the change should be OK, but neither on zc702 nor zc706 do I > see a difference in respect to deferred probes. With and without the > patch I see: > root@zynq:~# dmesg | grep -i defer > [ 0.097021] zynq-gpio e000a000.gpio: could not find pctldev for node /amba/slcr@f8000000/pinctrl@700/gpio0-default, deferring probe > root@zynq:~# > > If you have a case this patch improves things though, feel free to add my > Tested-by: Sören Brinkmann <soren.brinkmann@xilinx.com> > On the Florida boards there are i2c controlled clocks, power supplies and reset signals. Replacing the Cadence I2C controller with a GPIO-bitbang controller solved the I2C problems but caused a storm of dozens of deferred probes because of the pinmux driver arriving even after the first probe attempt of the i2c bus driver. Moving the pinmux driver to an earlier stage solved that problem neatly, now the "zynq-pinctrl 700.pinctrl: zynq pinctrl initialized" message appears after the OCM driver. Judging from your comment the GPIO driver still probes earlier (I don't have any GPIO-only pinmuxes yet), so maybe we should amend the patch to probe even earlier. The pinmux driver doesn't depend on anything, so it can potentially probe very early. What do you think? Mike. Kind regards, Mike Looijmans System Expert TOPIC Embedded Products Eindhovenseweg 32-C, NL-5683 KH Best Postbus 440, NL-5680 AK Best Telefoon: +31 (0) 499 33 69 79 Telefax: +31 (0) 499 33 69 70 E-mail: mike.looijmans@topicproducts.com Website: www.topicproducts.com Please consider the environment before printing this e-mail Visit us at : Aerospace Electrical Systems Expo Europe which will be held from 17.11.2015 till 19.11.2015, Findorffstrasse 101 Bremen, Germany, Hall 5, stand number C65 http://www.aesexpo.eu -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] pinctrl-zynq: Initialize early Mike Looijmans <mike.looijmans@topic.nl> - 2015-10-22 13:40 +0200
Re: [PATCH] pinctrl-zynq: Initialize early Mike Looijmans <mike.looijmans@topic.nl> - 2015-10-23 07:40 +0200
Re: [PATCH] pinctrl-zynq: Initialize early Mike Looijmans <mike.looijmans@topic.nl> - 2015-10-23 07:50 +0200
Re: [PATCH] pinctrl-zynq: Initialize early Linus Walleij <linus.walleij@linaro.org> - 2015-10-30 10:50 +0100
csiph-web