Re: [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2.

From	Jerome Glisse <j.glisse@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2.
Date	2015-10-23 06:00 +0200
Message-ID	<qmBGi-6uW-5@gated-at.bofh.it> (permalink)
References	<qmiX0-4m5-23@gated-at.bofh.it> <qmiX0-4m5-21@gated-at.bofh.it> <qmp2q-56v-13@gated-at.bofh.it> <qmBdf-5Xq-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Oct 23, 2015 at 11:23:26AM +0800, Hillf Danton wrote:
> > > > +	if (cnt_hmm_entry) {
> > > > +		int ret;
> > > > +
> > > > +		ret = hmm_mm_fork(src_mm, dst_mm, dst_vma,
> > > > +				  dst_pmd, start, end);
> > >
> > > Given start, s/end/addr/, no?
> > 
> > No, end is the right upper limit here.
> > 
> Then in the first loop, hmm_mm_fork is invoked for
> the _entire_ range, from input addr to end.
> In subsequent loops(if necessary), start is updated to
> addr, and hmm_mm_fork is also invoked for remaining
> range, from start to end.
> 
> Is the above overlap in range making sense?

Well yes and no, hmm_mm_fork() will do nothing for address >= addr
i feel like end is easier to understand.

Cheers,
Jérôme
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2. "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2015-10-22 10:00 +0200
  Re: [PATCH v11 02/14] HMM: add special swap filetype for memory  migrated to device v2. Jerome Glisse <jglisse@redhat.com> - 2015-10-22 16:30 +0200
    Re: [PATCH v11 02/14] HMM: add special swap filetype for memory migrated to device v2. "Hillf Danton" <hillf.zj@alibaba-inc.com> - 2015-10-23 05:30 +0200
      Re: [PATCH v11 02/14] HMM: add special swap filetype for memory  migrated to device v2. Jerome Glisse <j.glisse@gmail.com> - 2015-10-23 06:00 +0200

csiph-web