Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1253165

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU() macros

Show all headers | View raw

Dne 21.10.2015 v 21:27 Prarit Bhargava napsal(a):
> On 10/15/2015 04:16 PM, Michal Marek wrote:
>> Otherwise make tags can't parse them:
>>
>> ctags: Warning: arch/ia64/kernel/smp.c:60: null expansion of name pattern "\1"
>> ctags: Warning: drivers/xen/events/events_2l.c:41: null expansion of name pattern "\1"
>> ctags: Warning: drivers/acpi/processor_idle.c:64: null expansion of name pattern "\1"
>> ctags: Warning: kernel/locking/lockdep.c:153: null expansion of name pattern "\1"
>> ctags: Warning: kernel/workqueue.c:305: null expansion of name pattern "\1"
>> ctags: Warning: kernel/rcu/rcutorture.c:133: null expansion of name pattern "\1"
>> ctags: Warning: kernel/rcu/rcutorture.c:135: null expansion of name pattern "\1"
>> ctags: Warning: net/rds/page.c:45: null expansion of name pattern "\1"
>> ctags: Warning: net/ipv4/syncookies.c:53: null expansion of name pattern "\1"
>> ctags: Warning: net/ipv6/syncookies.c:44: null expansion of name pattern "\1"
> 
> I guarantee you're going to end up fixing this issue over and over again as more
> code is added in.

This is certainly going to happen, but it should be quickly spotted by
anybody running make tags on linux-next. And 10 instances since the
beginning of git is not too many.


> OOC, why not fix ctags to recognize newlines?

It's not ctags itself parsing the DEFINE_PER_CPU() macro, but a
user-supplied regex specified on commandline. Which can only operate on
single lines.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Prarit Bhargava <prarit@redhat.com> - 2015-10-21 21:30 +0200
  Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Michal Marek <mmarek@suse.com> - 2015-10-21 22:00 +0200
    Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Prarit Bhargava <prarit@redhat.com> - 2015-10-22 13:40 +0200
      Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Michal Marek <mmarek@suse.com> - 2015-10-22 14:10 +0200
        Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Prarit Bhargava <prarit@redhat.com> - 2015-10-22 14:20 +0200
          Re: [PATCH 9/9] treewide: Remove newlines inside DEFINE_PER_CPU()  macros Michal Marek <mmarek@suse.com> - 2015-10-22 14:30 +0200

csiph-web