Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read

From	Bartosz Golaszewski <bgolaszewski@baylibre.com>
Newsgroups	linux.kernel
Subject	Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read
Date	2015-10-21 16:50 +0200
Message-ID	<qm2Sd-606-11@gated-at.bofh.it> (permalink)
References	<qlAMh-6Wk-7@gated-at.bofh.it> <qlZrj-17w-11@gated-at.bofh.it> <qm2pc-5pS-7@gated-at.bofh.it> <qm2yS-5Ck-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

2015-10-21 16:23 GMT+02:00 Peter Korsgaard <peter@korsgaard.com>:
>>>>>> "Bartosz" == Bartosz Golaszewski <bgolaszewski@baylibre.com> writes:
>
>  >> As the serial number is available on a separate i2c address, wouldn't
>  >> it be simpler to handle these as special (read only) device variants and
>  >> instantiate E.G. a 24c64 (for the normal data) and a 24cs64 (for the
>  >> serial)?
>  >>
>
>  > Hi Peter,
>
>  > I wanted to respond that this way we would not be protected from
>  > concurrent accesses, but then I saw I didn't actually include any
>  > locks in the serial read function - my bad. It needs to be fixed as
>  > both memory blocks share the same address pointer.
>
>  > I'll resend the series.
>
> But we're protected by the i2c bus lock, right? You do a single
> i2c_transfer to read the serial number.

Why the at24->lock then?

Best regards,
Bartosz Golaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-10-20 10:50 +0200
  [RESEND PATCH 1/9] eeprom: at24: platform_data: use BIT() macro Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-10-20 11:00 +0200
  Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Peter Korsgaard <peter@korsgaard.com> - 2015-10-21 13:10 +0200
    Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-10-21 16:20 +0200
      Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Peter Korsgaard <peter@korsgaard.com> - 2015-10-21 16:30 +0200
        Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Bartosz Golaszewski <bgolaszewski@baylibre.com> - 2015-10-21 16:50 +0200
          Re: [RESEND PATCH 0/9] eeprom: at24: at24cs series serial number read Peter Korsgaard <peter@korsgaard.com> - 2015-10-21 17:10 +0200

csiph-web